Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't abort associations on unexpected Ack #18

Closed
jech opened this issue Jan 20, 2019 · 3 comments
Closed

Don't abort associations on unexpected Ack #18

jech opened this issue Jan 20, 2019 · 3 comments

Comments

@jech
Copy link
Member

jech commented Jan 20, 2019

Am I reading RFC 4960 wrong?

diff --git a/association.go b/association.go
index a65188d..b77daff 100644
--- a/association.go
+++ b/association.go
@@ -729,7 +729,8 @@ func (a *Association) handleChunk(p *packet, c chunk) ([]*packet, error) {
                        a.setState(cookieEchoed)
                        return pack(r), nil
                default:
-                       return nil, errors.Errorf("TODO Handle Init acks when in state %s", a.state.String())
+                       // RFC 4960 Section 5.2.3
+                       return nil, nil
                }
 
        case *chunkAbort:
@@ -778,7 +779,8 @@ func (a *Association) handleChunk(p *packet, c chunk) ([]*packet, error) {
                        close(a.handshakeCompletedCh)
                        return nil, nil
                default:
-                       return nil, errors.Errorf("TODO Handle Init acks when in state %s", a.state.String())
+                       // RFC 4960 Section 5.2.5
+                       return nil, nil
                }
 
                // TODO Abort
@Sean-Der Sean-Der transferred this issue from pion/webrtc Feb 18, 2019
@enobufs
Copy link
Member

enobufs commented Feb 18, 2019

You are right. @backkem pointed that out earlier also. We should be able to safely ignore them silently as the spec says.

Are you going to send a PR?

@jech
Copy link
Member Author

jech commented Mar 9, 2019

Please apply the patch yourself, github PRs are a pain.

@enobufs
Copy link
Member

enobufs commented Mar 15, 2019

This has been addressed in the PR #22

@enobufs enobufs closed this as completed Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants