We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Am I reading RFC 4960 wrong?
diff --git a/association.go b/association.go index a65188d..b77daff 100644 --- a/association.go +++ b/association.go @@ -729,7 +729,8 @@ func (a *Association) handleChunk(p *packet, c chunk) ([]*packet, error) { a.setState(cookieEchoed) return pack(r), nil default: - return nil, errors.Errorf("TODO Handle Init acks when in state %s", a.state.String()) + // RFC 4960 Section 5.2.3 + return nil, nil } case *chunkAbort: @@ -778,7 +779,8 @@ func (a *Association) handleChunk(p *packet, c chunk) ([]*packet, error) { close(a.handshakeCompletedCh) return nil, nil default: - return nil, errors.Errorf("TODO Handle Init acks when in state %s", a.state.String()) + // RFC 4960 Section 5.2.5 + return nil, nil } // TODO Abort
The text was updated successfully, but these errors were encountered:
You are right. @backkem pointed that out earlier also. We should be able to safely ignore them silently as the spec says.
Are you going to send a PR?
Sorry, something went wrong.
Please apply the patch yourself, github PRs are a pain.
This has been addressed in the PR #22
No branches or pull requests
Am I reading RFC 4960 wrong?
The text was updated successfully, but these errors were encountered: