Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sctp.Read sometimes returns DeadlineExceededError on past cancelled deadlines #296

Closed
sukunrt opened this issue Jan 25, 2024 · 1 comment
Assignees
Labels

Comments

@sukunrt
Copy link
Member

sukunrt commented Jan 25, 2024

Your environment.

  • Version: 1.8.7
  • Browser: NA
  • Other Information:
    We use pion/webrtc in go-libp2p for providing go nodes connectivity with browser libp2p nodes. In our testing environment we've observed some incorrect DeadlineExceededErrors from previous calls to SetReadDeadline after we had updated the Read deadline.
    The fix in check if deadline timer has been cancelled before signaling #290 ensures that any past deadline timer expiry that happens after SetReadDeadline returns is ignored.

What did you do?

Called SetReadDeadline multiple times

What did you expect?

After the last call to SetReadDeadline previous deadline timers should have been ignored

What happened?

Every once a while we observe a past deadline timer firing

@sukunrt
Copy link
Member Author

sukunrt commented Mar 2, 2024

fixed by #290

@sukunrt sukunrt closed this as completed Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants