Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ReadRTCP does not handle concatenated packets #18

Closed
kixelated opened this issue Mar 10, 2019 · 4 comments
Closed

ReadRTCP does not handle concatenated packets #18

kixelated opened this issue Mar 10, 2019 · 4 comments
Assignees
@wdouglass
Labels
triaged

Comments

@kixelated
Copy link
Contributor

It's valid to pass multiple RTCP packets in the same UDP packet. The UDP packet is decrypted correctly, but both rtcp.Unmarshal and ReadRTCP can only return a single packet. rtcp.Unmarshal will incorrectly assume the extra concatenated packets to be an extension, improperly ignoring the length header.
@kixelated
Copy link
Contributor Author

My current work-around is to use rtpSender.Read and rtcp.NewReader (which does correctly handle concatenated packets). It's 30 lines of code that could be removed if ReadRTCP returned an array of packets.

@wdouglass wdouglass self-assigned this Mar 11, 2019
@wdouglass
Copy link
Member

ReadRTCP should really call through to rtcp.Unmarshal, which should behave itself. I'll get a patch merged to fix rtcp.Unmarshal first

@Sean-Der
Copy link
Member

@wdouglass @maxhawkins @kixelated

Is this still an issue, I remember you all did a bunch of work around RTCP. I am just not up to date

@maxhawkins
Copy link
Contributor

This is fixed I believe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wdouglass wdouglass

Labels
triaged
Milestone
No milestone
Development

No branches or pull requests
4 participants
@maxhawkins @kixelated @Sean-Der @wdouglass