Skip to content
This repository has been archived by the owner on Jul 6, 2020. It is now read-only.

Duplicates settings actions in Editor Actions #26

Closed
kev-chien opened this issue Sep 24, 2016 · 1 comment
Closed

Duplicates settings actions in Editor Actions #26

kev-chien opened this issue Sep 24, 2016 · 1 comment
Labels
bug Dawn

Comments

@kev-chien
Copy link
Contributor

kev-chien commented Sep 24, 2016 •
edited
Loading

[In dawn/renderer/actions/EditorActions, the functions:

{ changeTheme, increaseFontsize, decreaseFontsize }

are duplicates in dawn/renderer/actions/SettingsActions.

As a result, my tests in branch dawn/actiontests may have to be changed as well to remove duplicates.
@AllanYangZhou AllanYangZhou changed the title Duplicates in Editor Actions Duplicates settings actions in Editor Actions Sep 25, 2016
@kevinmasd kevinmasd added the Dawn label Nov 11, 2016
@kev-chien kev-chien mentioned this issue Jan 7, 2017
Merged
@kev-chien
Copy link
Contributor Author

Closed with #91

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Dawn
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@AllanYangZhou @kevinmasd @kev-chien