Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Application Name filter for deployments #2496

Merged
merged 3 commits into from
Sep 20, 2021

Conversation

khanhtc1202
Copy link
Member

@khanhtc1202 khanhtc1202 commented Sep 17, 2021

What this PR does / why we need it:

It would work as below

Kapture.2021-09-18.at.18.58.49.mp4
  • filter directly with application id => query for specified application's deployments.
  • filter using application name => query for all deployments of applications named as same as input name.

Bonus

  • filter using application name also reflect the result to the application id field selectable options, only applications named as same as input name are remained.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

Add ApplicationName as a deployment filter on deployments list page

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 32.03%. This pull request does not change code coverage.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for javascript is 84.49%. This pull request decreases coverage by -0.06%.

File Base Head Diff
src/components/deployments-page/deployment-filter/index.tsx 100.00% 97.30% -2.70%
src/modules/deployments/index.ts 78.49% 76.84% -1.65%

@khanhtc1202 khanhtc1202 changed the title [WIP] Add Application Name filter for deployments Add Application Name filter for deployments Sep 17, 2021
@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 32.03%. This pull request does not change code coverage.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for javascript is 84.51%. This pull request decreases coverage by -0.04%.

File Base Head Diff
src/api/deployments.ts 57.14% 55.56% -1.59%
src/components/deployments-page/deployment-filter/index.tsx 100.00% 97.30% -2.70%

@pipecd-bot pipecd-bot added size/M and removed size/S labels Sep 18, 2021
@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 32.03%. This pull request does not change code coverage.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for javascript is 84.50%. This pull request decreases coverage by -0.05%.

File Base Head Diff
src/api/deployments.ts 57.14% 55.56% -1.59%
src/components/deployments-page/deployment-filter/index.tsx 100.00% 95.24% -4.76%

@nghialv
Copy link
Member

nghialv commented Sep 20, 2021

Really cool. Thank you.
/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nghialv.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit ebafc58 into master Sep 20, 2021
@pipecd-bot pipecd-bot deleted the add-application-name-filter branch September 20, 2021 23:48
@nghialv
Copy link
Member

nghialv commented Sep 21, 2021

/changelog

@pipecd-bot
Copy link
Collaborator

CHANGELOG

@nghialv: Changelog has been generated in response to this comment.

Details

Changelog since v0.16.2

Notable Changes

  • Add ApplicationName as a deployment filter on deployments list page (#2496)
  • Show all container image tags in the version string of application (#2495)
  • Remove the "--use-fake-api-client" option from Piped (#2492)

Internal Changes

  • Refine application version format (#2498)
  • Add log unary interceptor for WebAPI (#2497)
  • API add ability to filter deployments by application name (#2493)
  • Ensure fetch livestate whenever application kind is available (#2489)
  • Add analysis result store to fetch the most recent successful analysis (#2483)
  • Disable auto fetch application livestate on render application detail page (#2488)
  • Update memory size used to run Piped on CloudRun (#2487)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants