Fix wrong way to check unmergeable pull request #2278
Conversation
|
A Kapetanios build has just been triggered to run docker operations for the following
|
|
The Kapetanios build to run docker operations for the following 1. dockers/actions-plan-preview - failureAn image named actions-plan-preview:1.1.1-80f4f64 was procuded for reviewing and testing. There is no test to run inside this directory. |
dockers/actions-plan-preview/main.go
Outdated
| @@ -77,7 +77,7 @@ func main() { | |||
| return | |||
| } | |||
|
|
|||
| if !event.PRMergeable { | |||
| if event.PRMergeable != nil && *event.PRMergaeable == false { | |||
There was a problem hiding this comment.
| if event.PRMergeable != nil && *event.PRMergaeable == false { | |
| if event.PRMergeable != nil && !*event.PRMergaeable { |
There was a problem hiding this comment.
Compared to !*, I think the current one is clearer. Only me. 😄
There was a problem hiding this comment.
Well, what I can say is I would like to omit == bool since it is redundant to me, but get your point of the current method is more clear than that. So, it's up to you 🙆♀️
There was a problem hiding this comment.
It is. I would respect your feeling.
|
A Kapetanios build has just been triggered to run docker operations for the following
|
|
The Kapetanios build to run docker operations for the following 1. dockers/actions-plan-preview - failureAn image named actions-plan-preview:1.1.1-902101a was procuded for reviewing and testing. There is no test to run inside this directory. |
|
A Kapetanios build has just been triggered to run docker operations for the following
|
|
The Kapetanios build to run docker operations for the following 1. dockers/actions-plan-preview - successAn image named actions-plan-preview:1.1.1-53b1434 was procuded for reviewing and testing. There is no test to run inside this directory. |
|
/lgtm |
|
/approve |
|
This pull request is APPROVED by Approvers can cancel the approval by writing |
|
Code coverage for golang is |
What this PR does / why we need it:
The
mergeablefield will be nil while GitHub is running a job to check the mergeability.Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: