Add an ability to filter apps by labels #2987

nakabonne · 2021-12-24T02:23:33Z

What this PR does / why we need it:
Aside from AutocompleteI couldn't find out any material UI component which accepts multiple texts that look like those mentioned in the issue.

You can't select other than suggested options, that brings us a kind of validation for label format.

filtering-apps-by-labels.mov

Which issue(s) this PR fixes:

Fixes #2756
Ref #2978

Does this PR introduce a user-facing change?:

Filtering applications by Labels is now available

nakabonne · 2021-12-24T02:24:46Z

This is ready to be reviewed, but it must not get shipped until the next version will be out.
/hold

pipecd-bot · 2021-12-24T02:32:31Z

Code coverage for golang is 31.59%. This pull request does not change code coverage.

nghialv · 2021-12-24T03:02:17Z

This is ready to be reviewed, but it must not get shipped until the next version will be out.

I think we don't have to wait for that time. This can be normally included in the next release (v0.23.0).

The idea is to break the "filtering by label" feature into smaller ones:
"support filtering by labels for the Applications page"
and
"support for the Deployments page"

This PR is for the first one and will be included in v0.23.0.
The second one will be scheduled later.

nakabonne · 2021-12-24T03:18:16Z

@nghialv Technically we can 👍
I was just worried about the next version will be way too feature-packed. Including this filtering feature means including the Labels concept as well. If you are fine, I will get started preparing documentations for Labels concept.

nghialv · 2021-12-24T03:22:38Z

@nakabonne Nice point!
What kind of doc do you intend to have for the Label feature?

nakabonne · 2021-12-24T04:37:48Z

Pages needed to be updated are:

concepts/ - add Labels description
user-guide/adding-an-application/ - add an example of setting labels, and mention that Labels can be set only via an app config file.
Everywhere mentioning Environment- mark them deprecated

Seeing it actually, there is not that much to deal with.

nakabonne · 2021-12-24T04:56:41Z

Well, either way, it's fine to keep this PR hold if we can release v0.23.0 as soon as the new year starts 👍

nghialv · 2021-12-24T05:07:12Z

Well, either way, it's fine to keep this PR hold if we can release v0.23.0 as soon as the new year starts 👍

Yea. I'm fine with that way.

nghialv · 2021-12-24T05:09:02Z

concepts/ - add Labels description

nit: Label is an obvious one so maybe we don't need its definition.

nakabonne · 2022-01-04T01:20:25Z

/rebase

pipecd-bot · 2022-01-04T01:20:32Z

@nakabonne: Rebased this pull request in response to this comment.

pipecd-bot · 2022-01-04T01:28:17Z

Code coverage for golang is 31.57%. This pull request does not change code coverage.

pipecd-bot · 2022-01-04T01:37:16Z

Code coverage for javascript is 82.35%. This pull request decreases coverage by -0.27%.

File	Base	Head	Diff
src/api/applications.ts	`84.40%`	`83.78%`	`-0.62%`
src/components/applications-page/application-filter/index.tsx	`100.00%`	`76.09%`	`-23.91%`
src/modules/applications/index.ts	`83.13%`	`80.90%`	`-2.23%`
src/utils/search-params.ts	`70.00%`	`72.73%`	`+2.73%`

nakabonne · 2022-01-04T03:58:44Z

/rebase

pipecd-bot · 2022-01-04T03:58:50Z

@nakabonne: Rebased this pull request in response to this comment.

pipecd-bot · 2022-01-04T04:06:01Z

Code coverage for golang is 31.57%. This pull request does not change code coverage.

nakabonne · 2022-01-04T04:22:12Z

/trigger web-test

pipecd-bot · 2022-01-04T04:22:15Z

@nakabonne: Your requested web-test has been scheduled in response to this comment.

khanhtc1202 · 2022-01-04T04:37:51Z

Nice work, just one point I worried about. There is no way to make users know the format of labels they should use, so how about add things like this for Labels field

I mean, the title field is remained as Labels as you did, but for the placeholder, we can use text like in format key:value so that users could aware of what they should write there as a label, wdyt. Currently, the placeholder value is Labels which does not help very much
https://github.com/pipe-cd/pipe/pull/2987/files#diff-a4338d3a1daca78bef95b4f629ea59f0bc27b92d830427d34da256960e501e17R231

nakabonne · 2022-01-04T05:17:10Z

@khanhtc1202 Good idea! That placeholder is definitely more valuable!

nakabonne · 2022-01-04T05:20:49Z

@khanhtc1202 Applied your idea

pipecd-bot · 2022-01-04T05:29:01Z

Code coverage for golang is 31.57%. This pull request does not change code coverage.

nakabonne · 2022-01-04T05:37:39Z

/trigger web-test

pipecd-bot · 2022-01-04T05:37:42Z

@nakabonne: Your requested web-test has been scheduled in response to this comment.

khanhtc1202 · 2022-01-04T05:41:04Z

Nice work 👍
/lgtm

nakabonne · 2022-01-04T06:04:21Z

/trigger web-test

pipecd-bot · 2022-01-04T06:04:23Z

@nakabonne: Your requested web-test has been scheduled in response to this comment.

pipecd-bot · 2022-01-04T06:20:46Z

Code coverage for javascript is 82.35%. This pull request decreases coverage by -0.28%.

File	Base	Head	Diff
src/components/applications-page/application-filter/index.tsx	`100.00%`	`76.09%`	`-23.91%`
src/modules/applications/index.ts	`83.13%`	`80.90%`	`-2.23%`
src/api/applications.ts	`84.40%`	`83.78%`	`-0.62%`

nakabonne · 2022-01-04T07:38:37Z

https://github.com/pipe-cd/pipe/releases/tag/v0.23.0 got shipped which made this mergeable.
/hold cancel

nghialv · 2022-01-04T11:29:31Z

Great!
/approve

pipecd-bot · 2022-01-04T11:29:35Z

This pull request is APPROVED by nghialv.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

khanhtc1202 · 2022-01-04T13:10:55Z

/trigger web-test

pipecd-bot · 2022-01-04T13:10:57Z

@khanhtc1202: Your requested web-test has been scheduled in response to this comment.

nakabonne · 2022-01-05T01:22:30Z

/trigger web-test

pipecd-bot · 2022-01-05T01:22:33Z

@nakabonne: Your requested web-test has been scheduled in response to this comment.

nakabonne · 2022-01-05T01:44:02Z

/trigger web-test

pipecd-bot · 2022-01-05T01:44:04Z

@nakabonne: Your requested web-test has been scheduled in response to this comment.

nakabonne · 2022-01-05T01:44:34Z

It's rare for web-test to succeed anymore 😓

nakabonne · 2022-01-05T02:02:13Z

/trigger web-test

pipecd-bot · 2022-01-05T02:02:15Z

@nakabonne: Your requested web-test has been scheduled in response to this comment.

**What this PR does / why we need it**: This PR adds an ability to filter deployments by Labels like [the applications page](#2987). Keep in mind the GIF animation below is what merges the MORE button PR (#2999). ![Kapture 2022-01-05 at 15 17 06](https://user-images.githubusercontent.com/19730728/148169587-7ee2c3ab-da0c-4d65-843a-9cfb13899f44.gif) **Which issue(s) this PR fixes**: Fixes #2978 Fixes #2757 **Does this PR introduce a user-facing change?**:  ```release-note Filtering deployments by Labels is now available ``` This PR was merged by Kapetanios.

pipecd-bot added size/M area/web labels Dec 24, 2021

pipecd-bot requested review from khanhtc1202, knanao and nghialv December 24, 2021 02:23

pipecd-bot added the do-not-merge/hold label Dec 24, 2021

pipecd-bot force-pushed the feature-label-filtering branch from 6949c67 to 23fe5cc Compare January 4, 2022 01:20

Add an ability to filter apps by labels

e9c2b8c

pipecd-bot force-pushed the feature-label-filtering branch from 23fe5cc to e9c2b8c Compare January 4, 2022 03:58

Use "key:value" as a placeholder

6132fb1

pipecd-bot added the lgtm label Jan 4, 2022

pipecd-bot removed the do-not-merge/hold label Jan 4, 2022

pipecd-bot added the approved label Jan 4, 2022

pipecd-bot merged commit d2fb908 into master Jan 5, 2022

pipecd-bot deleted the feature-label-filtering branch January 5, 2022 02:20

nakabonne mentioned this pull request Jan 5, 2022

Enable to filter deployments by Labels #3000

Merged

This was referenced Jan 13, 2022

Show label on the app detail and list page #3011

Merged

Emphasize deprecated config fields in the doc #3028

Merged

Add a pipectl command to migrate deployment configuration files to application configuration files #3048

Merged

Add an ability to filter apps by labels #2987

Add an ability to filter apps by labels #2987

Conversation

nakabonne commented Dec 24, 2021

nakabonne commented Dec 24, 2021

pipecd-bot commented Dec 24, 2021

nghialv commented Dec 24, 2021

nakabonne commented Dec 24, 2021

nghialv commented Dec 24, 2021

nakabonne commented Dec 24, 2021

nakabonne commented Dec 24, 2021

nghialv commented Dec 24, 2021

nghialv commented Dec 24, 2021

nakabonne commented Jan 4, 2022

pipecd-bot commented Jan 4, 2022

pipecd-bot commented Jan 4, 2022

pipecd-bot commented Jan 4, 2022

nakabonne commented Jan 4, 2022

pipecd-bot commented Jan 4, 2022

pipecd-bot commented Jan 4, 2022

nakabonne commented Jan 4, 2022

pipecd-bot commented Jan 4, 2022

khanhtc1202 commented Jan 4, 2022 • edited Loading

nakabonne commented Jan 4, 2022

nakabonne commented Jan 4, 2022

pipecd-bot commented Jan 4, 2022

nakabonne commented Jan 4, 2022

pipecd-bot commented Jan 4, 2022

khanhtc1202 commented Jan 4, 2022

nakabonne commented Jan 4, 2022

pipecd-bot commented Jan 4, 2022

pipecd-bot commented Jan 4, 2022

nakabonne commented Jan 4, 2022

nghialv commented Jan 4, 2022

pipecd-bot commented Jan 4, 2022

khanhtc1202 commented Jan 4, 2022

pipecd-bot commented Jan 4, 2022

nakabonne commented Jan 5, 2022

pipecd-bot commented Jan 5, 2022

nakabonne commented Jan 5, 2022

pipecd-bot commented Jan 5, 2022

nakabonne commented Jan 5, 2022

nakabonne commented Jan 5, 2022

pipecd-bot commented Jan 5, 2022

khanhtc1202 commented Jan 4, 2022 •

edited

Loading