Put deprecated notes on the Environment tab #3022
Conversation
| @@ -76,6 +82,13 @@ export const SettingsIndexPage: FC = memo(function SettingsIndexPage() { | |||
| activeClassName={classes.activeNav} | |||
| > | |||
| <ListItemText primary={text} /> | |||
| {link === PAGE_PATH_SETTINGS_ENV && ( | |||
There was a problem hiding this comment.
not sure why do we need this check? 🤔
There was a problem hiding this comment.
Because this is only for the Environment tab, but am I correct?
There was a problem hiding this comment.
If this condition check exists, when we click on other tabs on the left sidebar, the warning will disappear. I think it should keep be shown even if users click on other tabs on the left sidebar, wdyt?
There was a problem hiding this comment.
Actually it doesn't disappear even if you click on other tabs.
There was a problem hiding this comment.
The variable name may be a bit confusing, but it just tells it to show the Icon only if it is a ListItem for Environment.
There was a problem hiding this comment.
Ah okay, I get the point 👍 Thank you.
|
Code coverage for golang is |
Co-authored-by: Le Van Nghia <nghialv2607@gmail.com>
|
Code coverage for golang is |
|
Code coverage for javascript is |
|
Nice |
|
/approve |
|
This pull request is APPROVED by Approvers can cancel the approval by writing |
What this PR does / why we need it:
Whenever you hover over the Environment tab at the settings page, you will see the notes "deprecated".
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: