Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better detection of free port to bind to #637

Merged
merged 2 commits into from
Feb 15, 2023
Merged

Conversation

gkresic
Copy link
Contributor

@gkresic gkresic commented Feb 15, 2023

As requested in #632 (comment)

@gkresic
Copy link
Contributor Author

gkresic commented Feb 15, 2023

@decebals Same error as for #636

Error:  Failed to execute goal org.sonarsource.scanner.maven:sonar-maven-plugin:3.9.1.2184:sonar (sonar) on project pippo-pac4j: Project not found. Please check the 'sonar.projectKey' and 'sonar.organization' properties, the 'SONAR_TOKEN' environment variable, or contact the project administrator -> [Help 1]

mvn test and mvn verify are passing, so tests are probably OK, but GitHub Action runs mvn -B verify -Pcoverage,sonar which (I guess) requires credentials for SonarQube which (again, guess) should be somewhere within this project's secrets? Interestingly, tests for #635 passed - may it have something to do on who makes a PR?

@mhagnumdw
Copy link
Member

Please see if it is possible to remove the constants MIN_PORT_NUMBER and MAX_PORT_NUMBER. Since within the classe themselves they are no longer used.

@gkresic
Copy link
Contributor Author

gkresic commented Feb 15, 2023

Done, removed both constants and unused AvailablePortFinder.findAvailablePort(int, int)

@decebals decebals merged commit b6d240b into pippo-java:master Feb 15, 2023
@gkresic gkresic deleted the ports branch February 15, 2023 17:33
@mhagnumdw
Copy link
Member

Tks @gkresic !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants