JedisSessionDataStorageTest fails on machine that has Redis running

[gkresic]

Caused by JedisSessionDataStorageTest.setUpClass using default constructor of RedisServer which tries to bind to default port 6379. If that port is taken (by another Redis running), this "test server" can not be started and test fails:

https://github.com/pippo-java/pippo/blob/master/pippo-session-parent/pippo-session-jedis/src/test/java/ro/pippo/session/jedis/JedisSessionDataStorageTest.java#L39

Instead, test case should find an free port and initialize RedisServer using that port.

I'll try to submit a PR.

[mhagnumdw]

Maybe the pippo-test/src/main/java/ro/pippo/test/AvailablePortFinder.java class will be useful.

[gkresic]

Didn't know about that one (I'm new to the project).

Adapting to be uniform, but version I used initially looks better: let OS determine free port instead of iterating through a port range. Maybe it should be used as a better implementation for AvailablePortFinder.findAvailablePort? Full disclosure: I didn't invent that new implementation, found it on Baeldung.

[mhagnumdw]

@gkresic , feel free to change the implementation of the AvailablePortFinder.findAvailablePort method in a new PR.