Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add smoke test #467

Merged
merged 6 commits into from
Mar 18, 2019
Merged

Add smoke test #467

merged 6 commits into from
Mar 18, 2019

Conversation

godwhoa
Copy link
Member

@godwhoa godwhoa commented Mar 18, 2019

No description provided.

@godwhoa godwhoa added the WIP This PR is still being worked on and is not to be merged label Mar 18, 2019
@godwhoa godwhoa removed the WIP This PR is still being worked on and is not to be merged label Mar 18, 2019
@godwhoa godwhoa requested a review from NotAFile March 18, 2019 11:00
@NotAFile
Copy link
Member

I wonder if we could or should get coverage for these runs

.travis.yml Outdated
@@ -17,6 +17,7 @@ script:
- python setup.py develop
- pytest --cov=piqueserver --cov=pyspades
- travis_retry coveralls
- ./scripts/smoke_test.py -t 25
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

25s seems like a lot of time


def printer(buffer, prefix):
def p(data):
buffer.write(prefix+data)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pep8

@godwhoa godwhoa merged commit d5201f2 into master Mar 18, 2019
@godwhoa godwhoa deleted the smoketest branch March 31, 2019 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants