Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect EOF when reading VXL files #496

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

NotAFile
Copy link
Member

Previously this just caused a very annoying segfault crash. Now we raise
a C++ exception (which cython turns into a python exceptions), which is
much more helpful.

Previously this just caused a very annoying segfault crash. Now we raise
a C++ exception (which cython turns into a python exceptions), which is
much more helpful.
@godwhoa godwhoa self-requested a review April 26, 2019 06:02
Copy link
Member

@godwhoa godwhoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Unit test would be nice.

@NotAFile
Copy link
Member Author

I wonder how we could unit test this without having 100MB of map files in our repo. Perhaps we could generate simple patterns on the fly... The VXL format is pretty simple.

Another thing I noticed is that it would be better and safer to just calculate the highest address instead of checking before each access. There's no point in checking every item if you can just check if there's enough space for the last one.

@feikname feikname added the PR: improvement This PR includes an enhancement to piqueserver label Dec 2, 2019
@NotAFile
Copy link
Member Author

NotAFile commented Dec 8, 2019

This is really annoying because I can't reproduce this. Where is it going wrong?

Perhaps we should build with asan in CI?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: improvement This PR includes an enhancement to piqueserver
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants