Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ganon version 1.0.0 #181

Merged
merged 9 commits into from
Aug 23, 2021
Merged

ganon version 1.0.0 #181

merged 9 commits into from
Aug 23, 2021

Conversation

pirovc
Copy link
Owner

@pirovc pirovc commented Aug 20, 2021

ganon version 1.0.0

  • upgrade from seqan2-dev branch to seqan3-main branch
    • drop support for clang and MacOS (seqan3 works only with gcc7 or higher)
    • offset calculation on ganon side (before was part of seqan2 ibf implementation)
    • sdsl lite directly included with seqan3 as submodule
    • k-mer size not contained on the ibf anymore
  • refactor tests on the c++ side using minimal auto-generated data instead of file comparison

ganon-build:

  • input of size by mb (filter) or bits for each bin
  • change Seqs and Fragbin strucute on ganon-build to avoid thread access to map
  • ganon-build works with only sequence inputs (seqid_bin optional), creating one bin for each sequence

ganon-classify:

  • improved stats and print unique matches
  • fix bug in threshold calculation with offset and paired reads - extra_pos was not properly counted for second pair
  • works with only ibf and reads as input (map and tax optional), generating auto increment ids as bin targets.
  • if map is present name/group bins
  • if tax is present perform lca
  • output .rep by default (STDOUT) instead of .lca
  • do not write .lca by default (new option --output-lca)

pirovc and others added 9 commits July 6, 2021 14:54
* version 1.0.0

* added seqan3 as module, compiling on cmake, working

* building with Seqan3

* working classify

* working with wrappers

* test ssh connection

* pull seqan3

* seqan2 removed

* tests python passing, fixing cpp test

* cpp tests build passing

* remove bkp files

* test working, but not passing. Small differences in counting

* remove sdsl-lite lib cmake

* remove include sdsl

* fix test, disable offset tests

* fix files test

* remove incompatible test travis

* better agent and hash

* better parsing reads

* update seqan3.1.0

* format

* offset with views

* fix print uint8_t

* fix missing sum paired

* fixed threshold calculation

* fix min-kmers threshold calculation

* validate 0 min_kmers

* improve build code

* auto type hashes to compile gcc7
* new cpp tests ganon-build

* more tests build and update

* remove data files ganon-build tests

* remove copy cmake, add missing file
* io ganon-build, automatic bin per file

* improved code ganon-build and auto bin generation working

* default output rep, optional lca output

* option to output lca on python side

* one kmer size per hierarchical level

* working without map and tax

* code improv.

* fixed map size with auto bins

* fix tests
* Report per threads, without atomic int

* stats reporting unique

* count unique without lca, better print stats

* fix copy filters function validate_targets_tax

* fix stats float

* better stats struct, account for skipped reads
* new classify tests cpp

* remove files test classify, do not copy over cmake

* more tests ganon-classify

* added test tax

* more tests classify, output in folders

* adding tests classify with errors

* more tests with errors

* more tests

* more tests
* validate input files

* error msg

* generalized filesystem import via seqan3
@pirovc pirovc merged commit 2154627 into master Aug 23, 2021
@pirovc pirovc deleted the dev branch October 26, 2021 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant