Skip to content

Commit

Permalink
Instead of calling private delay_play directly when the opening ani…
Browse files Browse the repository at this point in the history
…mation has finished, a new event `"openingDone"` is triggered on the instance. The `delay_play` then becomes a callback for the event bound one level up the DOM to the overlay node (instance's parent). This way it is cancellable on the instance either by using event's `.stopPropagation()` or by returning false from the handler. Fixes #65
  • Loading branch information
pisi committed Oct 31, 2011
1 parent f62ae07 commit 36c8bdb
Show file tree
Hide file tree
Showing 4 changed files with 68 additions and 28 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.markdown
Expand Up @@ -12,6 +12,8 @@ Development (edge)
(GH-62).
* Proper image preload events unbinding on teardown (GH-64).
* Option `scrollable` can disable page scrolling (if needed) on touch devices.
* New event `"openingDone"` now announces the end of opening animation
(GH-65).


Version 1.1.3
Expand Down

0 comments on commit 36c8bdb

Please sign in to comment.