Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Order of arguments #6

Closed
Ryuno-Ki opened this issue Nov 6, 2019 · 0 comments
Closed

Order of arguments #6

Ryuno-Ki opened this issue Nov 6, 2019 · 0 comments
Assignees
@pitchmuc
Labels
documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers

Comments

@Ryuno-Ki
Copy link

Ryuno-Ki commented Nov 6, 2019

https://github.com/pitchmuc/adobe_analytics_api_2.0/blob/04e29001025a6440e972efe6b1b9f292aac956a8/adobe_analytics_2/aanalytics2.py#L69

I'd suggest to put the most likely changed argument first. I feel, that this would be the save argument here.
@pitchmuc pitchmuc self-assigned this Feb 11, 2021
@pitchmuc pitchmuc added documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers labels Feb 11, 2021
@pitchmuc pitchmuc closed this as completed Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pitchmuc pitchmuc

Labels
documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Ryuno-Ki @pitchmuc