Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid Pokémon exception handling #8

Closed
Ryuno-Ki opened this issue Nov 6, 2019 · 1 comment
Closed

Avoid Pokémon exception handling #8

Ryuno-Ki opened this issue Nov 6, 2019 · 1 comment
Assignees
@pitchmuc

Comments

@Ryuno-Ki
Copy link

Ryuno-Ki commented Nov 6, 2019

Please try to avoid Pokémon exception handling in
https://github.com/pitchmuc/adobe_analytics_api_2.0/blob/04e29001025a6440e972efe6b1b9f292aac956a8/adobe_analytics_2/aanalytics2.py#L139

If I read the docs right, you should handle a ValueError instead.
@pitchmuc
Copy link
Owner

pitchmuc commented Nov 7, 2019

Again good point!
I changed it and it will be part of the next release.
Thanks again.
All of these comments are super useful for me to improve !

@pitchmuc pitchmuc closed this as completed Nov 7, 2019
@pitchmuc pitchmuc self-assigned this Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pitchmuc pitchmuc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Ryuno-Ki @pitchmuc