Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky UI tests #204

Closed
LorenzoBettini opened this issue Aug 24, 2022 · 1 comment
Closed

Flaky UI tests #204

LorenzoBettini opened this issue Aug 24, 2022 · 1 comment
Assignees
Labels
for: CI 🚀 Related to Continuous Integration

Comments

@LorenzoBettini
Copy link
Collaborator

Some UI tests involving the "PIT Mutations" view are flaky, especially in Windows and macOS. The toolbar buttons cannot be found, but that is due to the view itself not being active.

In particular, this condition does not seem to make sense:

class ViewOpenedCondition extends DefaultCondition {
    
    private SWTWorkbenchBot bot;
    private String viewTitle;

    public ViewOpenedCondition(SWTWorkbenchBot bot, String viewTitle) {
        this.bot = bot;
        this.viewTitle = viewTitle;
    }
    
    @Override
    public boolean test() throws Exception {
        return bot.viewByTitle(viewTitle) != null;
    }

since the return value of viewByTitle cannot be null. Instead, if we use as condition isActive on the returned view, we get the failing condition.

The screenshots upon failures are of this shape (macOS, Windows and Linux, respectively):

image

image

image

meaning that the "PIT Mutations" view is not active at all.

Investigating in #203

@LorenzoBettini LorenzoBettini self-assigned this Aug 24, 2022
@LorenzoBettini LorenzoBettini added the for: CI 🚀 Related to Continuous Integration label Aug 24, 2022
@LorenzoBettini
Copy link
Collaborator Author

Closed by #203

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
for: CI 🚀 Related to Continuous Integration
Projects
None yet
Development

No branches or pull requests

1 participant