Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

re-write tests for lab to mock requests #173

Closed
nij-patel opened this issue May 23, 2024 · 4 comments · Fixed by #159
Closed

re-write tests for lab to mock requests #173

nij-patel opened this issue May 23, 2024 · 4 comments · Fixed by #159
Assignees
@nij-patel

Comments

@nij-patel
Copy link
Member

No description provided.

@nij-patel nij-patel self-assigned this May 23, 2024
@tianyizheng02
Copy link
Contributor

@Steven-Jarmell already does this in #159, but that PR hasn't been approved and merged yet. That PR also removes the mocked tests for the people module, so we'll need to exclude that change from the PR if we wanna merge that one.

@nij-patel
Copy link
Member Author

I think Steven might be busy right now, so I was planning on merging those changes through here

potentially with the new devs being onboarded soon

@Steven-Jarmell
Copy link
Contributor

@tianyizheng02 We can close this one too

@tianyizheng02 tianyizheng02 linked a pull request Jul 3, 2024 that will close this issue
Lab refactor #159
Merged
@tianyizheng02
Copy link
Contributor

@nij-patel Since we've merged Steven's PR, we no longer need the 173-re-write-tests-for-lab-to-mock-requests branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nij-patel nij-patel

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@tianyizheng02 @Steven-Jarmell @nij-patel