Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to change color order #77

Closed
TravisRoy opened this issue Oct 4, 2021 · 5 comments
Closed

Ability to change color order #77

TravisRoy opened this issue Oct 4, 2021 · 5 comments
Labels
enhancement New feature or request wontfix This will not be worked on

Comments

@TravisRoy
Copy link

My LEDs seem to have a different color order than what PixelIt is sending. WLED has the option to change it.
Screen Shot 2021-10-04 at 10 52 11 AM

@o0shojo0o o0shojo0o added the enhancement New feature or request label Oct 4, 2021
@o0shojo0o
Copy link
Member

I had a quick look yesterday, it should be possible.

As soon as I'm done with the new UI I'll take a closer look at this topic.

However, this may take some time because I currently can not spend much time.

@o0shojo0o
Copy link
Member

Unfortunately I was too optimistic here, I use FastLED to control the LEDs, this lib does not allow me to set the color order at runtime (FastLED/FastLED#282 (comment)).

I have to compile every color order and the memory of the ESP8266 doesn't support that, it's just too small.

@o0shojo0o o0shojo0o added the wontfix This will not be worked on label Oct 16, 2021
@o0shojo0o
Copy link
Member

However, you can create a custom version where you only need to adjust the code in three places.
https://github.com/o0shojo0o/PixelIt/blob/c3429897945d4815e5970459dc6e1c4cc014d7b5/src/PixelIt.ino#L1990-L2003

For GRB it would look like this:

 // Matrix Color Correction 
 if (userLEDCorrection != UncorrectedColor) 
 { 
 	FastLED.addLeds<WS2812B, MATRIX_PIN, GRB>(leds, NUMMATRIX).setCorrection(userLEDCorrection); 
 } 
 else if (userColorTemp != UncorrectedTemperature) 
 { 
 	FastLED.addLeds<WS2812B, MATRIX_PIN, GRB>(leds, NUMMATRIX).setTemperature(userColorTemp); 
 } 
 else 
 { 
 	int *rgbArray = GetUserCutomCorrection(); 
 	FastLED.addLeds<WS2812B, MATRIX_PIN, GRB>(leds, NUMMATRIX).setCorrection(matrix->Color(rgbArray[0], rgbArray[1], rgbArray[2])); 
 } 

@o0shojo0o
Copy link
Member

Which color order do you need?

@TravisRoy
Copy link
Author

I'm pretty sure I need the WS2812B order

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants