-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating gitignore to exclude build directories #134
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor changes to ignorefile
I am not a fan of putting words sandwiched between wildcards. With this ignore file we are going to ignore any use the word 'build' in any file even if it is a file we may want to add in the future. |
We currently have an issue with people adding build directories to the base directory that are accidentally getting tracked by git. Do you have another suggestion to ignore build directories? |
I'm not sure what you mean? The I also do not have an issue with git informing you that you have put a something in a trackable location. The user does not need to commit it. Maybe |
We are having issues with directories named things like |
What goes in there? An alternate suggestion is to add These are the questions I think we need to ask for adding items to gitignore:
Are those reasonable items to consider? Any other suggestions? If multiple people will be creating folders like that and expect them to be ignored I would say to go ahead with your change. |
That's a question I'm not sure about. I think that your last suggestion |
Updating gitignore to exclude build directories Former-commit-id: c9cc188
Trace Filtering and Asynchronous histogram writing
No description provided.