Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating gitignore to exclude build directories #134

Merged
merged 2 commits into from
Nov 30, 2016
Merged

Conversation

spaulaus
Copy link
Member

No description provided.

Copy link

@yongchix yongchix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor changes to ignorefile

@ksmith0
Copy link
Contributor

ksmith0 commented Nov 30, 2016

I am not a fan of putting words sandwiched between wildcards. With this ignore file we are going to ignore any use the word 'build' in any file even if it is a file we may want to add in the future.

@spaulaus
Copy link
Member Author

We currently have an issue with people adding build directories to the base directory that are accidentally getting tracked by git. Do you have another suggestion to ignore build directories?

@ksmith0
Copy link
Contributor

ksmith0 commented Nov 30, 2016

I'm not sure what you mean? The build/ ignores the build directory in the base level of the repo. If people make this folder at a lower level you may have problems.

I also do not have an issue with git informing you that you have put a something in a trackable location. The user does not need to commit it.

Maybe */build/ is a better choice?

@spaulaus
Copy link
Member Author

spaulaus commented Nov 30, 2016

We are having issues with directories named things like cmake-build-debug. I agree that the user does not need to commit it, but we have already had instances in other repositories of people committing these directories by accident due to inattentive git adds and git commit -as

@ksmith0
Copy link
Contributor

ksmith0 commented Nov 30, 2016

What goes in there? An alternate suggestion is to add build/ again and then add an additional statement for these folders. Maybe *-build-debug/ or *-debug/ or *-build-*/.

These are the questions I think we need to ask for adding items to gitignore:

  • Is this item unique to the current development work and will not be committed?
  • Is the wild card statement too broad?
  • Will someone pulling the repo expect that file to be ignored?

Are those reasonable items to consider? Any other suggestions? If multiple people will be creating folders like that and expect them to be ignored I would say to go ahead with your change.

@spaulaus
Copy link
Member Author

That's a question I'm not sure about. I think that your last suggestion *-build-*/, should encompass most of those types of scenarios? I agree that the *build* is too broad. However, we have to try and make sure that people do not unintentionally pollute the repository with things like this. Especially when those of us with knowledge of these types of things move to other positions.

@spaulaus spaulaus merged commit c9cc188 into dev Nov 30, 2016
@spaulaus spaulaus deleted the ignorefile-update branch November 30, 2016 17:58
akeeler pushed a commit to akeeler/paass that referenced this pull request Mar 7, 2017
Updating gitignore to exclude build directories

Former-commit-id: c9cc188
spaulaus added a commit to spaulaus/paass that referenced this pull request Nov 21, 2020
Trace Filtering and Asynchronous histogram writing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants