Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Echo suppressor definition doesn't match the declaration #43

Closed
pjsipbot opened this issue Dec 12, 2006 · 0 comments
Closed

Echo suppressor definition doesn't match the declaration #43

pjsipbot opened this issue Dec 12, 2006 · 0 comments

Comments

@pjsipbot
Copy link
Collaborator

2006-12-12 14:38:03: @bennylp created the issue on trac ticket 43

the declaration of fun echo_supp_create in file
pjproject-0.5.9\pjmedia\src\pjmedia\echo_suppress.c
has only 6 parameters;
 
PJ_DECL(pj_status_t) echo_supp_create(pj_pool_t *pool,
          unsigned clock_rate,
          unsigned samples_per_frame,
          unsigned tail_ms,
          unsigned options,
          void **p_state );
 
 
However, there are 7 parameters in the declaration in file
pjproject-0.5.9\pjmedia\src\pjmedia\echo_common.c
 
PJ_DECL(pj_status_t) echo_supp_create(pj_pool_t *pool,
          unsigned clock_rate,
          unsigned samples_per_frame,
          unsigned tail_ms,
          unsigned latency_ms,            // not appear in echo_suppress.c
          unsigned options,
          void **p_state );
 
No error appear when compling and linking, but not run correctly;

2006-12-12 14:38:40: @bennylp changed status from new to assigned


2006-12-12 14:38:40: @bennylp edited the issue description


2006-12-15 11:57:56: @bennylp changed status from assigned to closed


2006-12-15 11:57:56: @bennylp set resolution to fixed


2006-12-15 11:57:56: @bennylp commented

Fixed in r855

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants