Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsound usages of unsafe implementation from buf to Page #37

Open
llooFlashooll opened this issue Aug 20, 2024 · 0 comments
Open

Unsound usages of unsafe implementation from buf to Page #37

llooFlashooll opened this issue Aug 20, 2024 · 0 comments

Comments

@llooFlashooll
Copy link

Hi, I am scanning the jammdb in the latest version with my own static analyzer tool.

Unsafe conversion found at: src/tx.rs#L329

if let TxLock::Rw(file) = &mut self.lock {
   // write meta page to file
   {
         let mut buf = vec![0; self.db.inner.pagesize as usize];

         #[allow(clippy::cast_ptr_alignment)]
         let page = unsafe { &mut *(&mut buf[0] as *mut u8 as *mut Page) };
         let meta_page_id = u64::from(self.meta.meta_page == 0);

This unsound implementation would create a misalignment issues if the type size of buf is smaller than the type size of Page.

This would potentially cause undefined behaviors in Rust. If we further manipulate the problematic converted types, it would potentially lead to different consequences such as access out-of-bound. I am reporting this issue for your attention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant