Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include black and white colors in canviz.js #14

Closed
GoogleCodeExporter opened this issue Feb 12, 2016 · 1 comment
Closed

Include black and white colors in canviz.js #14

GoogleCodeExporter opened this issue Feb 12, 2016 · 1 comment

Comments

@GoogleCodeExporter
Copy link

Using named colors in graphs that will be drawn by Canviz is not recommended 
because then you 
must include the color lookup table gvcolors.js which is an extra thing that 
needs to be sent to the 
browser. Better to not use named colors. But Graphviz itself uses the color 
names "black" and 
"white" all over the graph even though you didn't tell it to. So that you can 
actually use Canviz 
without loading gvcolors.js, we should define a tiny 2-entry gvcolors array in 
canviz.js itself, just 
for black and white.

Original issue reported on code.google.com by ryandesi...@gmail.com on 8 Oct 2008 at 10:11

@GoogleCodeExporter
Copy link
Author

Fixed in r119. Also added "lightgrey" since that's the default fill color for 
filled nodes. Note that gvcolors.js is 
now called x11colors.js.

Original comment by ryandesi...@gmail.com on 14 Oct 2008 at 7:13

  • Changed state: Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant