Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Versioning and breaking change in MemProfile{Heap,Allocs} signatures #59

Closed
mmcloughlin opened this issue May 5, 2021 · 4 comments
Closed

Comments

@mmcloughlin
Copy link

Commit 3704c8d changed the signatures of MemProfile{Heap,Allocs}. Is this going to require a v2?

@davecheney
Copy link
Member

If it did, i'm sorry, but I'm not going to do the v2 nonsense. Sorry.

@mmcloughlin
Copy link
Author

Not a problem, I was just curious how you intended to handle it.

@davecheney
Copy link
Member

Thanks for catching it. It’s hard to remember back a year but if I did spot the comparison break, which I probably didn’t, I would have said “nah, not worth v2”. This is probably still true.

@mmcloughlin
Copy link
Author

Yeah I think you're fine. I assume very few are affected and the fix is removing parens (). But you'd minimize the impact by tagging v1.6.0 now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants