Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Basic methods for DigitalOcean DNS #229

Closed
wants to merge 1 commit into from

Conversation

mmalecki
Copy link
Contributor

@mmalecki mmalecki commented Jan 9, 2014

This is a WIP. Implemented methods already work.

@kenperkins what do we do with methods which aren't supported by Rackspace? Do we throw in DigitalOcean or limit to subset supported by both providers (so no bulk write methods, mostly)?

@kenperkins
Copy link
Member

Can you enumerate the methods which aren't supported by rackspace?

@mmalecki
Copy link
Contributor Author

mmalecki commented Jan 9, 2014

I meant the other way: bulk write methods like createZones/updateZones aren't supported by DO.

@kenperkins
Copy link
Member

Well we have at least a couple of options:

  1. leave bulk functions out of the generalized portion
  2. implement bulk functions in the SDK (making multiple calls behind the scenes)
  3. ??

I'd go with no 1 for now, as the generalization for DNS is still primitive. See #165 for vocabulary. Maybe this should be moved into https://github.com/nodejitsu/pkgcloud/blob/master/docs/vocabulary.md

@indexzero
Copy link
Member

Agree with going for No. 1 here @kenperkins.

@mmalecki Nice work on this. A couple of minor things:

  1. We should probably respond with something likenew Error('Not implemented) for all the stubs you didn't implement.
  2. I'll defer to @kenperkins here, but he seems pretty gung-ho about method comments in a JSDoc style. We should be consistent for new providers.

@indexzero indexzero mentioned this pull request Mar 31, 2014
9 tasks
@kenperkins kenperkins changed the title [wip] Basic methods for DigitalOcean DNS [WIP] Basic methods for DigitalOcean DNS Aug 28, 2014
@kenperkins
Copy link
Member

ping

@mmalecki
Copy link
Contributor Author

@kenperkins I will do this this weekend, hopefully together with migrating to newer DO API version (I promise!)

@kenperkins
Copy link
Member

Keep @mikeal in the loop, he was possibly going to do some DO stuff as well.

@mmalecki
Copy link
Contributor Author

I'm going to close this since it's going to be implemented in #325.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants