Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Incomplete precisNormalization handling (accents/diacritics) #3

Open
vanbroup opened this issue Apr 14, 2021 · 0 comments
Open

Incomplete precisNormalization handling (accents/diacritics) #3

vanbroup opened this issue Apr 14, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@vanbroup
Copy link
Contributor

The precisNormalization is not handeling all accents/diacritics, for example:

	"AD": {
		complete: false,
		regions: map[string]bool{
			"ANDORRA LA VELLA":    true,
			"ANDORRA VELLA":       true,
			"CANILLO":             true,
			"ENCAMP":              true,
			"ESCALDES ENGORDANY":  true,
			"LA MASSANA":          true,
			"MASSANA":             true,
			"ORDINO":              true,
			"SANT JULIÀ DE LÒRIA": true,
			"SANT JULIÀ LÒRIA":    true,
		},
	},

Should also include the values with the accents/diacritics replaced:

	"AD": {
		complete: false,
		regions: map[string]bool{
			"ANDORRA LA VELLA":    true,
			"ANDORRA VELLA":       true,
			"CANILLO":             true,
			"ENCAMP":              true,
			"ESCALDES ENGORDANY":  true,
			"LA MASSANA":          true,
			"MASSANA":             true,
			"ORDINO":              true,
			"SANT JULIA DE LORIA": true,
			"SANT JULIÀ DE LÒRIA": true,
			"SANT JULIA LORIA":    true,
			"SANT JULIÀ LÒRIA":    true,
		},
	},

https://github.com/pkic/regions/blob/main/check/regions_map.go#L20

@vanbroup vanbroup added the bug Something isn't working label Apr 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant