Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve current code by using the converters provided by discord.py #49

Closed
PKlempe opened this issue Aug 13, 2020 · 0 comments · Fixed by #51
Closed

Improve current code by using the converters provided by discord.py #49

PKlempe opened this issue Aug 13, 2020 · 0 comments · Fixed by #51
Assignees
@PKlempe
Labels
enhancement New feature or request
Milestone
v1.0

Comments

@PKlempe
Copy link
Owner

PKlempe commented Aug 13, 2020

Instead of parsing IDs or mentions ourselve we should use the converters provided by the library. This way we don't need to handle a lot of stuff like getting a Channel or User object and checking if the input is valid.
@PKlempe PKlempe added the enhancement New feature or request label Aug 13, 2020
@PKlempe PKlempe added this to the Running Prototype milestone Aug 13, 2020
@PKlempe PKlempe self-assigned this Aug 13, 2020
PKlempe added a commit that referenced this issue Aug 13, 2020
@PKlempe
#49: Use converters provided by discord.py where it makes sense and o…
d738d9b 
…ther small improvements
@PKlempe PKlempe mentioned this issue Aug 13, 2020
Merged
PKlempe added a commit that referenced this issue Aug 13, 2020
@PKlempe
Merge pull request #51 from PKlempe/feature/#49-use-converters
b52a234 
#49: Use converters provided by discord.py where it makes sense and o…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PKlempe PKlempe

Labels
enhancement New feature or request
Projects
None yet
Milestone
v1.0
Development

Successfully merging a pull request may close this issue.

#49: Use converters provided by discord.py where it makes sense and o… PKlempe/SAM
1 participant
@PKlempe