Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compare with fdupes #25

Closed
piranna opened this issue Aug 27, 2020 · 6 comments
Closed

Compare with fdupes #25

piranna opened this issue Aug 27, 2020 · 6 comments
Labels
documentation Improvements or additions to documentation

Comments

@piranna
Copy link

piranna commented Aug 27, 2020

Add a compare with fdupes: performance, features...

@pkolaczk
Copy link
Owner

pkolaczk commented Aug 27, 2020

The benchmarks in README.md already include fdupes.
But why do you think comparing features would be useful?
I don't want to do this, because this could become very long and it can easily be perceived as claiming "my program is better than yours" which I want to avoid. I listed the features of fclones in detail, isn't it sufficient?

@piranna
Copy link
Author

piranna commented Aug 27, 2020

Sorry for the benchmarks, didn't see them before, really are impresive 👍

Competition is not bad if it allow for improvement. One of the things I mostly miss from fdupes is that's not possible to include as a library, while with Rust is fairly easy :-) My question was more about to compare what features does each one offer. For example, a feature I use a lot from fdupes is the option to delete files interactively, I don't see any flag for fclones to do so :-)

@pkolaczk
Copy link
Owner

That's right, fclones doesn't offer any way of deleting files automatically yet. I believe this is a task for a different program (or a subcommand) that would take output of fclones.

@pkolaczk pkolaczk added the documentation Improvements or additions to documentation label Aug 27, 2020
@piranna
Copy link
Author

piranna commented Aug 28, 2020

From a UNIX perspective, yes, it makes sense that task being done by another command, but being so much attached to fclones output format... :-/ Maybe a shell script wrapper that offer a compatible interface with fdupes? :-) That would be easy to implement, but not sure if It should be hosted here un fclones repo or being totally independent...

@aurelg
Copy link

aurelg commented Sep 14, 2020

Follow-up proposed in #27

@pkolaczk
Copy link
Owner

pkolaczk commented Sep 19, 2020

To wrap it up:

  • Benchmarks are included in README
  • I added the Limitations section to the README

Let me close this and leave #27 as the main ticket for adding the automatic file removal feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants