Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker image for OJS 3.3.0-10 #158

Closed
mgax opened this issue Mar 14, 2022 · 7 comments
Closed

Docker image for OJS 3.3.0-10 #158

mgax opened this issue Mar 14, 2022 · 7 comments

Comments

@mgax
Copy link

mgax commented Mar 14, 2022

OJS 3.3.0-10 was released on March 5 but there is currently no Docker image for it.


I assume the process of configuring an image for a new OJS version involves some manual steps; what could be done to make it easier? I'm willing to help.
Perhaps it would be useful to have a periodic Action that checks if there is a new tagged OJS version, and triggers an alert if there is no corresponding Docker image?

@marcbria
Copy link
Collaborator

marcbria commented Mar 15, 2022

Long story short: My fault.
Got error due gitHub resource limit when building all images and I just forget.
Image build is in gitLab and now also pushed to dockerHub.

Extended information:
As far as dockerHub autobuild tools were removed, we are evaluating gitLab as an alternative.
If you don't find them in dockerHub, you can get the images there: https://gitlab.com/pkp-org/docker/ojs/container_registry

If you like, you can call them directly in your docker-compose as follows:
image: registry.gitlab.com/pkp-org/docker/ojs:3_3_0-10

Is not clear if images will be built in gitLab or gitHub (Actions will be also reviewed).
Once we have a more clear pipeline, the idea is keeping images in gitLab/github but also pushed in dockerHub.

@marcbria
Copy link
Collaborator

I missed saying thanks for the advice.

BTW @mgax could you explain how are you using those docker images?
For dev or production? With the suggested docker-compose or your own? With docker or other?

It will help us to know what need to be prioritized.

Cheers,
m.

@mgax
Copy link
Author

mgax commented Mar 16, 2022

could you explain how are you using those docker images?
For dev or production? With the suggested docker-compose or your own? With docker or other?

Sure thing. It's a production deployment which is based on a docker-compose example in this repo.

I've copied the directory from here: https://github.com/pkp/docker-ojs/tree/2b175ba207602e80f950502b40365ec2f5477764/versions/3_3_0-3/alpine/apache/php73 and changed docker-compose.yml and root/etc/apache2/conf.d/ojs.conf. Here is my current docker-compose.yml without the secrets: https://gist.github.com/mgax/8521194c6bce32b5c9dfd41712c871b1. I've also extracted config.inc.php outside the container to persist the site's configuration.


I missed saying thanks for the advice.

Edit: my pleasure, thanks for taking the time to make OJS and dockerize it; once I got it working it was easy to tweak and keep it up to date!

@mgax
Copy link
Author

mgax commented Mar 16, 2022

If you like, you can call them directly in your docker-compose as follows:
image: registry.gitlab.com/pkp-org/docker/ojs:3_3_0-10

Alright, I've switched to the gitlab registry, thanks for the tip!

@marcbria
Copy link
Collaborator

Alex, I'm doing an issues dump to see what needs to be fixed and what works.

Right now I would say that the dockerHub and gitLab images are in sync.

Can you confirm that everything is working correctly to close the issue?

@mgax
Copy link
Author

mgax commented Apr 11, 2022

Can you confirm that everything is working correctly to close the issue?

I'm running the image pulled from gitLab and it's working fine. Thanks!

@mgax mgax closed this as completed Apr 11, 2022
@marcbria
Copy link
Collaborator

Thanks for your feedback.

The idea is keep gitLab and dockerHub repos sync.
Till then... as far as we are building in gitLab, you have more changes to get the last image there.

Any problem, suggestion or comment is welcome.

Cheers,
m.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants