Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When using the sandbox API, the ORCID validator can't validate #142

Closed
jmacgreg opened this issue Jul 16, 2020 · 2 comments
Closed

When using the sandbox API, the ORCID validator can't validate #142

jmacgreg opened this issue Jul 16, 2020 · 2 comments
Assignees

Comments

@jmacgreg
Copy link

A regular ORCID ID looks like this (and must include the URL):

https://orcid.org/0000-0003-3530-156X

When a journal uses the sandbox options with the ORCID plugin, the ORCID IDs become:

https://sandbox.orcid.org/0000-0003-3530-156X

However the ORCID field validator isn't written to permit the inclusion of "sandbox" in the ID string. It should permit this option, only when the sandbox options are being used.

@davidjb
Copy link

davidjb commented Apr 27, 2021

I've noticed this when testing this plugin on OJS 3.3; saving any forms with ORCID iD fields on them (e.g Profile -> Public; Edit User; Edit Contributor) fail to save, either requiring the ORCID iD field to be a maximum of 37 characters, the length of the URL without the sandbox. prefix, or otherwise reporting the ORCID iD is invalid, like this on the Edit Contributor form:

The ORCID iD you specified is invalid. Please include the full URI (e.g. "https://orcid.org/0000-0002-1825-0097").

The only way around this currently is to delete the contents of the text input, if visible, or in the case of the Edit Contributor form, edit the value attribute of the hidden ORCID iD field in the browser Inspector before clicking save:

<input type="hidden" maxlength="37" validation="" class="field text" name="orcid" value="https://sandbox.orcid.org/0000-0123-4567-8900" id="orcid-123213412">

@withanage
Copy link
Member

withanage commented May 2, 2021

Hi @davidjb ,

This needed changes to main OJS pkp-lib library and the plugin code base. I have requested a review from @asmecher .
As soon as he has reviewed , I will integrate the changes and release appropriate versions OJS/OPA 3.3.0, 3.3.1 and OJS/O
PS 3.2.1
Please bear with me, that the plugin will be released, after the ORCID API 3 update. #171

If you like to contribute by doing a functional test or would like to apply the changes instantly, please apply these changes to the
local system.
https://github.com/pkp/pkp-lib/pull/7010/files
and
https://github.com/pkp/orcidProfile/pull/174/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants