-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When using the sandbox API, the ORCID validator can't validate #142
Comments
I've noticed this when testing this plugin on OJS 3.3; saving any forms with ORCID iD fields on them (e.g Profile -> Public; Edit User; Edit Contributor) fail to save, either requiring the ORCID iD field to be a maximum of 37 characters, the length of the URL without the
The only way around this currently is to delete the contents of the text input, if visible, or in the case of the Edit Contributor form, edit the <input type="hidden" maxlength="37" validation="" class="field text" name="orcid" value="https://sandbox.orcid.org/0000-0123-4567-8900" id="orcid-123213412"> |
Hi @davidjb , This needed changes to main OJS pkp-lib library and the plugin code base. I have requested a review from @asmecher . If you like to contribute by doing a functional test or would like to apply the changes instantly, please apply these changes to the |
A regular ORCID ID looks like this (and must include the URL):
https://orcid.org/0000-0003-3530-156X
When a journal uses the sandbox options with the ORCID plugin, the ORCID IDs become:
https://sandbox.orcid.org/0000-0003-3530-156X
However the ORCID field validator isn't written to permit the inclusion of "sandbox" in the ID string. It should permit this option, only when the sandbox options are being used.
The text was updated successfully, but these errors were encountered: