Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate Client-Id and secret in Settings and en-/disable plugin #161

Closed
withanage opened this issue Jan 18, 2021 · 3 comments
Closed

Validate Client-Id and secret in Settings and en-/disable plugin #161

withanage opened this issue Jan 18, 2021 · 3 comments
Assignees

Comments

@withanage
Copy link
Member

withanage commented Jan 18, 2021

Is your feature request related to a problem? Please describe.

Journal managers / journal editors configure the plugin incorrectly in the settings.

Possible reasons

  • Incorrect ORCID-Token - 64 characters string
  • Incorrect Client-ID - (APP-[\da-zA-Z]{16}|(\d{4}-){3,}\d{3}[\dX])
  • Missing ORCID-Token and/or Client-ID

Describe the solution you'd like

Disable the plugin for users and co-authors, if there are configuration errors.

@withanage withanage self-assigned this Jan 18, 2021
@withanage withanage changed the title Captuers errors in Plugin-setting Capture errors in Plugin-setting Jan 18, 2021
@withanage
Copy link
Member Author

FYI @sheilarabun

@withanage
Copy link
Member Author

@sheilarabun

I have released the following plugin versions addressing this.

OJS 3.1 https://github.com/pkp/orcidProfile/releases/tag/v1_1_1-12
OJS 3.2 https://github.com/pkp/orcidProfile/releases/tag/v1_1_2-7

Both versions are available in Plugin-Gallery.

Remarks

  • Validation rule for client secret is from 36 to 64 characters. It is a loose-mechanism, but at lease will check for a-f letters, numbers and -
  • Plugin is disabled, when there are validation errors
orcid.mp4

Demo

OJS 3.3 will follow

@withanage withanage changed the title Capture errors in Plugin-setting Validate Clinet-Id and secret in Settings and en-/disable plugin Feb 28, 2021
@withanage withanage changed the title Validate Clinet-Id and secret in Settings and en-/disable plugin Validate Client-Id and secret in Settings and en-/disable plugin Mar 1, 2021
@withanage
Copy link
Member Author

OJS/OPS 3.3 version with this issue requirements released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant