Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OMP] Onix export record references are not unique for each pub format #10173

Open
kaitlinnewson opened this issue Jul 8, 2024 · 2 comments
Open
Assignees
Milestone

Comments

@kaitlinnewson
Copy link
Member

kaitlinnewson commented Jul 8, 2024

Describe the bug
In the Onix export plugin in OMP, each "product" (publication format) has a <RecordReference>. For a publication that has more than one publication format, there will be multiple <RecordReference> tags in the output XML.

Currently these are the same for every publication format, but they should be unique for each in order to align with the ONIX standard, and ensure that records can be identified by a unique identifier and differentiated from each other. We should also change how we are setting them to better align with best practices (see link below for more info on recommendations).

If we upgrade to newer versions of Onix, the current implementation will cause validation to fail as it will be enforced in future versions (e.g. 3.0.8).

This is a potentially breaking change, as it changes the identifiers for all of these records once we fix it. It has the potential to create duplicate records if the XML is being imported and is using these tags to check if the record exists already.

What application are you using?
OMP 3.3/3.4/main

Additional information

@bozana
Copy link
Collaborator

bozana commented Jul 11, 2024

Is there a possible solution for the duplicate records? Or is this what will happen however and we cannot do anything?

@bozana
Copy link
Collaborator

bozana commented Oct 31, 2024

I found this document https://www.editeur.org/files/ONIX%203/APPNOTE%20Deletions%20in%20ONIX.pdf. Would it be possible for us to use code 05 to mark that old product metadata are wrong, and how should we actually do it?

@kaitlinnewson kaitlinnewson added this to the 3.5.0 LTS milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants