Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OJS] ORCID Profile Plugin: Sandbox iDs not stored or displayed correctly on the article page #4893

Closed
gmejias opened this issue Jul 4, 2019 · 5 comments
Assignees

Comments

@gmejias
Copy link

gmejias commented Jul 4, 2019

After entering the ORCID Member API Sandbox credentials it's possible to successfully connect the Sandbox iD but OJS links to orcid.org instead of sandbox.orcid.org

It seems that that OJS cant handle Sandbox iDs, the internal validation doesn't allow them to be stored and they are not displayed correctly on the article page.

@isgrim

@nils-stefan-weiher
Copy link

Thanks for posting this. As I wrote in a second email, I mixed something up. Sandbox iDs are stored, but they are not shown as sandbox iDs on the article page, only in the backend contributor form and user profile.

There is also another major issue with displaying ORCID iDs currently in OJS 3.1.2-1 reported in the forum:
https://forum.pkp.sfu.ca/t/orcid-icon-problem/53637

Maybe this can be tackled together.

@nils-stefan-weiher
Copy link

So more clarification, I'm very sorry I was too hasty. I should have looked at the code first.

Currently Sandbox ORCID iDs are stored as normal ORCID iDs ... this is undesirde. There exists a separate field "orcidSandbox" which declares them as Sandbox. This was a workaround due to the limitation of the "orcid" Field validation, only allowing producation ORCID iDs.

But since with the plugin no more manual entry of ORCID iDs is permitted the validation is not needed, and so I would rewrite the storing and display of sandbox iDs.

@nils-stefan-weiher
Copy link

@asmecher You can assign me to this

@asmecher
Copy link
Member

asmecher commented Jul 4, 2019

Thanks for looking at this, @isgrim!

@withanage
Copy link
Member

Is in Version 1.1.1-2 in Plugin gallery

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants