Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User register template: check if site-wide privacy statement is enabled #4967

Open
Vitaliy-1 opened this issue Jul 31, 2019 · 0 comments
Open

Comments

@Vitaliy-1
Copy link
Collaborator

Templates from the current master branch of OJS and themes

  1. This condition checks if there is any site-wide registration info entered in the form but similar call in registrationFormContext.tpl checks if the setting is enabled in the config. The former could be changed to: {if $siteWidePrivacyStatement && $enableSiteWidePrivacyStatement} for consistency. If a user disables site-wide privacy statement from the config, it will nevertheless appear on the sitewide registration page if the data to the correspondent form was previously entered from a dashboard.
  2. Inputs for sitewide registration are now situated in 2 places: registrationFormContext.tpl and its parent userRegister.tpl: https://github.com/pkp/pkp-lib/blob/master/templates/frontend/pages/userRegister.tpl#L125-L164. My proposal is to move all that data to the former template, to keep it in one place.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant