Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the native import/export plugin to OPS 3.3.0-x #7639

Closed
jonasraoni opened this issue Jan 20, 2022 · 8 comments
Closed

Add support for the native import/export plugin to OPS 3.3.0-x #7639

jonasraoni opened this issue Jan 20, 2022 · 8 comments
Assignees
Labels
Enhancement:1:Minor A new feature or improvement that can be implemented in less than 3 days. Hosting Bug reports and feature requests from Publishing Services's hosted clients.
Milestone

Comments

@jonasraoni
Copy link
Contributor

jonasraoni commented Jan 20, 2022

Describe the problem you would like to solve
The current release of OPS doesn't support the XML tooling for importing/exporting data.

Describe the solution you'd like
Merge some updates from the /main branch to the stable-3_3_0 branch to make this functionality available.

Who is asking for this feature?
System administrators looking forward to migrate data from other systems.

PRs
pkp/ops#223
#7640

@jonasraoni jonasraoni added Hosting Bug reports and feature requests from Publishing Services's hosted clients. Enhancement:1:Minor A new feature or improvement that can be implemented in less than 3 days. labels Jan 20, 2022
@jonasraoni jonasraoni self-assigned this Jan 20, 2022
jonasraoni added a commit to jonasraoni/pkp-lib that referenced this issue Jan 20, 2022
jonasraoni added a commit to jonasraoni/ops that referenced this issue Jan 20, 2022
jonasraoni added a commit to jonasraoni/ops that referenced this issue Jan 20, 2022
jonasraoni added a commit to jonasraoni/ops that referenced this issue Jan 20, 2022
jonasraoni added a commit to jonasraoni/ops that referenced this issue Jan 20, 2022
@jonasraoni
Copy link
Contributor Author

Hi @asmecher!

I've created draft PRs, later I'll recheck if the basic features (import/export through the CLI and web interface) are still working fine after rebasing.

I've been using these updates to import data locally, and everything seems to be working fine... Most of the changes are additions. The modified parts are inside classes related to the native import/export plugin.

@asmecher
Copy link
Member

@defstat, could you review these?

@jonasraoni, I'm assuming you went back to the commits where this was first added to main and cherry-picked them to stable-3_3_0? Or did you bring in the files from main and back-port them to compatibility with stable-3_3_0 again? Just to know what to look for.

@jonasraoni
Copy link
Contributor Author

If I remember well:
#7640: Cherry picked the first commit + adjusts.
pkp/ops#223: Grabbed the needed files from /main + adjusts.

@NateWr NateWr changed the title [OPS] Add support for the native import/export plugin Add support for the native import/export plugin to OPS 3.3.0-x Jan 24, 2022
@NateWr NateWr added this to the 3.3.0-9 milestone Jan 24, 2022
@asmecher asmecher modified the milestones: 3.3.0-9, 3.3.0-10 Mar 1, 2022
@asmecher
Copy link
Member

@jonasraoni, that's a lot more code being added to stable-3_3_0 lib/pkp than I expected naively; is there really no impact on the OJS and OMP stable branch?

@jonasraoni
Copy link
Contributor Author

@asmecher I just checked and I fully agree, I think these PRs were a kind of draft.
I'll check if it's possible to decrease the amount of changes.

Anyway, let me know if you're ok to get this amount of code merged in 3.3.0... Then, given that most of changes are additions, I can just test the updates against OJS/OMP.

@asmecher
Copy link
Member

Unless the potential impact can be brought down on OJS/OMP 3.3.0-x, I'd suggest just leaving these changes to the 3.4.0 release. If someone has a firm requirement for this support in 3.3.0-x, please speak up!

@asmecher
Copy link
Member

Let's leave this as a thing to be added to an install for anyone who needs it -- but unless there's a compelling reason to merge disruptive changes to stable-3_3_0 (especially for pkp-lib) I'd rather not merge. Thanks all!

@jonasraoni
Copy link
Contributor Author

Yeah! That's what I've told to Michael. It's still useful for those who really need to import data into OPS 3.3 :)

Also, I can confirm all the code here can be applied temporarily, just to get the imported data in place, then it might be fully reverted to the base branch (stable-3_3_0) without issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement:1:Minor A new feature or improvement that can be implemented in less than 3 days. Hosting Bug reports and feature requests from Publishing Services's hosted clients.
Projects
None yet
Development

No branches or pull requests

4 participants