-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix remaining missing foreign key declarations #8333
Closed
12 tasks done
asmecher opened this issue
Oct 14, 2022
· 4 comments
· Fixed by pkp/ojs#3946, pkp/omp#1423, pkp/ops#543, #10023 or pkp/customBlockManager#86
Closed
12 tasks done
Fix remaining missing foreign key declarations #8333
asmecher opened this issue
Oct 14, 2022
· 4 comments
· Fixed by pkp/ojs#3946, pkp/omp#1423, pkp/ops#543, #10023 or pkp/customBlockManager#86
Labels
Housekeeping:1:Todo
Any dependency management or refactor that would be nice to have some day.
Milestone
Comments
This was referenced Jun 7, 2023
jonasraoni
added a commit
to jonasraoni/pkp-lib
that referenced
this issue
Jun 7, 2023
jonasraoni
added a commit
to jonasraoni/pkp-lib
that referenced
this issue
Jun 7, 2023
jonasraoni
added a commit
to jonasraoni/ojs
that referenced
this issue
Jun 7, 2023
jonasraoni
added a commit
to jonasraoni/ojs
that referenced
this issue
Jun 7, 2023
jonasraoni
added a commit
to jonasraoni/omp
that referenced
this issue
Jun 7, 2023
jonasraoni
added a commit
to jonasraoni/ops
that referenced
this issue
Jun 7, 2023
I've updated the issue description (added the missing |
jonasraoni
added a commit
to jonasraoni/pkp-lib
that referenced
this issue
Jun 8, 2023
jonasraoni
added a commit
to jonasraoni/pkp-lib
that referenced
this issue
Jun 8, 2023
jonasraoni
added a commit
to jonasraoni/pkp-lib
that referenced
this issue
Jun 8, 2023
jonasraoni
added a commit
to jonasraoni/pkp-lib
that referenced
this issue
Jun 9, 2023
asmecher
pushed a commit
that referenced
this issue
Jun 9, 2023
* #9069 Added missing pre-foreign key cleanups * #9069 Organized the migration code * #9069 Added automated code while keeping the customizations * #9069 Added code to consider the dependencies when running the entity cleanup * #9069 Added code to ignore a couple of special values, which will be handled by later migrations * #9069 Added code to dynamically ignore nonexistent entities (review_*) * #9069 Moved cleanup of notifications.user_id to the foreign key migration and fixed typo * #9069 Added code to drop existing foreign keys * #9069 Updated cleanup to consider a database without the foreign keys from #8333 * #9069 Delegated cleanup of future foreign keys to #8333
jonasraoni
added a commit
to jonasraoni/pkp-lib
that referenced
this issue
Jun 9, 2023
jonasraoni
added a commit
to jonasraoni/pkp-lib
that referenced
this issue
Jul 24, 2024
jonasraoni
added a commit
to jonasraoni/pkp-lib
that referenced
this issue
Jul 24, 2024
jonasraoni
added a commit
to jonasraoni/pkp-lib
that referenced
this issue
Jul 24, 2024
jonasraoni
added a commit
to jonasraoni/pkp-lib
that referenced
this issue
Jul 24, 2024
…cation_subscription_settings.context_id
jonasraoni
added a commit
to jonasraoni/pkp-lib
that referenced
this issue
Jul 24, 2024
jonasraoni
added a commit
to jonasraoni/ojs
that referenced
this issue
Jul 24, 2024
jonasraoni
added a commit
to jonasraoni/ojs
that referenced
this issue
Jul 24, 2024
jonasraoni
added a commit
to jonasraoni/ojs
that referenced
this issue
Jul 24, 2024
jonasraoni
added a commit
to jonasraoni/ojs
that referenced
this issue
Jul 24, 2024
jonasraoni
added a commit
to jonasraoni/ojs
that referenced
this issue
Jul 24, 2024
jonasraoni
added a commit
to jonasraoni/ojs
that referenced
this issue
Jul 24, 2024
jonasraoni
added a commit
to jonasraoni/ojs
that referenced
this issue
Jul 24, 2024
jonasraoni
added a commit
to jonasraoni/ojs
that referenced
this issue
Jul 24, 2024
jonasraoni
added a commit
to jonasraoni/ojs
that referenced
this issue
Jul 24, 2024
jonasraoni
added a commit
to jonasraoni/omp
that referenced
this issue
Jul 24, 2024
jonasraoni
added a commit
to jonasraoni/omp
that referenced
this issue
Jul 24, 2024
jonasraoni
added a commit
to jonasraoni/omp
that referenced
this issue
Jul 24, 2024
jonasraoni
added a commit
to jonasraoni/omp
that referenced
this issue
Jul 24, 2024
jonasraoni
added a commit
to jonasraoni/omp
that referenced
this issue
Jul 24, 2024
jonasraoni
added a commit
to jonasraoni/omp
that referenced
this issue
Jul 24, 2024
jonasraoni
added a commit
to jonasraoni/omp
that referenced
this issue
Jul 24, 2024
…remaining-fks##
jonasraoni
added a commit
to jonasraoni/ops
that referenced
this issue
Jul 24, 2024
jonasraoni
added a commit
to jonasraoni/ops
that referenced
this issue
Jul 24, 2024
jonasraoni
added a commit
to jonasraoni/ops
that referenced
this issue
Jul 24, 2024
jonasraoni
added a commit
to jonasraoni/ops
that referenced
this issue
Jul 24, 2024
…remaining-fks##
jonasraoni
added a commit
to pkp/staticPages
that referenced
this issue
Jul 24, 2024
…g-fks pkp/pkp-lib#8333 Replaced CONTEXT_ID_NONE by SITE_CONTEXT_ID
jonasraoni
added a commit
to jonasraoni/ojs
that referenced
this issue
Jul 24, 2024
…remaining-fks##
jonasraoni
added a commit
to jonasraoni/omp
that referenced
this issue
Jul 24, 2024
…remaining-fks##
jonasraoni
added a commit
to jonasraoni/ops
that referenced
this issue
Jul 24, 2024
…remaining-fks##
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Housekeeping:1:Todo
Any dependency management or refactor that would be nice to have some day.
This issue is a continuation of #6093.
The remaining missing foreign key constraints will require some code changes to move away from the use of
0
as a reserved case.lib/pkp/classes/migration/install/CommonMigration.php
:site.redirect
(renamed to redirect_context_id)plugin_settings.context_id
(uses0
for site-wide)notifications.context_id
(uses0
for site-wide)notifications.user_id
(uses0
for "anyone" IIRC)notification_subscription_settings
(just needs the field to be renamed fromcontext
tocontext_id
)lib/pkp/classes/migration/install/LogMigration.php
:email_log.sender_id
(uses0
for "nobody in particular")lib/pkp/classes/migration/install/MetadataMigration.php
:filters.context_id
(uses0
for site-wide)filters.parent_filter_id
(uses0
for none)lib/pkp/classes/migration/install/NavigationMenusMigration.php
:navigation_menus.context_id
(0
used for site-wide)navigation_menu_items.context_id
(0
used for site-wide)navigation_menu_items_assignments.parent_id
(0
apparently used for none, even though the field appears nullable)lib/pkp/classes/migration/install/classes/RolesAndUserGroupsMigration.php
:user_groups.context_id
(0
used for side-wide)notification_subscription_settings
Some of these areas are slated for rewriting, so this work may be a lower priority than the rewrite.
It makes sense to keep the
email_log
even when a sender (user) is deleted, but it's probably needed to review GDPR (e.g. right to be forgotten), as the email might keep personal data.The text was updated successfully, but these errors were encountered: