Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/main/8333 Add remaining FKs #3946

Merged
merged 10 commits into from
Jul 24, 2024
Merged

Feature/main/8333 Add remaining FKs #3946

merged 10 commits into from
Jul 24, 2024

Conversation

jonasraoni
Copy link
Contributor

No description provided.

@jonasraoni jonasraoni changed the title Feature/main/8333 add remaining fks Feature/main/8333 Add remaining FKs Jun 7, 2023
@jonasraoni jonasraoni linked an issue Jun 7, 2023 that may be closed by this pull request
Fix remaining missing foreign key declarations pkp/pkp-lib#8333
Open
12 tasks
@jonasraoni jonasraoni force-pushed the feature/main/8333-add-remaining-fks branch 2 times, most recently from f505fb2 to 977a9e8 Compare June 9, 2023 20:33
asmecher
asmecher reviewed Jun 13, 2023
View reviewed changes
dbscripts/xml/upgrade.xml Outdated Show resolved Hide resolved
@jonasraoni jonasraoni force-pushed the feature/main/8333-add-remaining-fks branch 4 times, most recently from 8f05d05 to e4d94d2 Compare June 19, 2024 21:52
@jonasraoni jonasraoni force-pushed the feature/main/8333-add-remaining-fks branch 8 times, most recently from 300e058 to 50ff929 Compare July 1, 2024 22:13
@jonasraoni jonasraoni force-pushed the feature/main/8333-add-remaining-fks branch 2 times, most recently from 6a0fb12 to eb0fd49 Compare July 8, 2024 11:31
@jonasraoni jonasraoni force-pushed the feature/main/8333-add-remaining-fks branch 7 times, most recently from 9008b69 to cbccd89 Compare July 16, 2024 13:05
@jonasraoni
Copy link
Contributor Author

@asmecher you may review this PR and the one for pkp-lib, the others are outdated.

I've tried to deprecate/merge constants from the Application, and use null everywhere instead of converting to/from 0.
Special cases are using Application::SITE_CONTEXT_ID_ALL.

@jonasraoni
Copy link
Contributor Author

A mixed type could make things clearer for the programmer (which functions work with the site context) int|SiteContext $contextId.

asmecher
asmecher requested changes Jul 16, 2024
View reviewed changes
Copy link
Member

@asmecher asmecher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment or two!

classes/issue/Collector.php Show resolved Hide resolved
classes/services/StatsIssueService.php Show resolved Hide resolved
@jonasraoni jonasraoni force-pushed the feature/main/8333-add-remaining-fks branch from cbccd89 to ba72d66 Compare July 23, 2024 15:21
@jonasraoni jonasraoni force-pushed the feature/main/8333-add-remaining-fks branch 2 times, most recently from 114702d to e25c6db Compare July 23, 2024 20:37
@jonasraoni jonasraoni force-pushed the feature/main/8333-add-remaining-fks branch from e25c6db to fe30b1b Compare July 24, 2024 22:20
@jonasraoni jonasraoni merged commit d3214bd into pkp:main Jul 24, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asmecher asmecher asmecher requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix remaining missing foreign key declarations
2 participants
@jonasraoni @asmecher