Controlled vocabularies are being URL decoded at input time

[jonasraoni]

Describe the bug
When inserting a controlled vocabulary item, the data is being URL decoded, which ends up changing the user input.

To Reproduce

1. Access a submission
2. Add a keyword with a text which is sensible for the urldecode() function, for example +test
3. Check the saved data and see the plus is gone.

What application are you using?
*/stable-3_3_0
*/main

PRs
stable-3_3_0

• pkp/pkp-lib#8511 Removed urldecode() from controlled vocabularies #8513
• [TESTS ONLY] pkp/pkp-lib#8511 Submodule update ##jonasraoni/bugfix/stable-3_3_0/8511-drop-urldecode-from-vocabs## ojs#3678

main

• Bugfix/main/8511 drop urldecode from vocabs #8515
• [TESTS ONLY] pkp/pkp-lib#8511 Submodule update ##jonasraoni/bugfix/main/8511-drop-… ojs#3681

[jonasraoni]

@asmecher Just to confirm, the urldecode() is just a fragment from the past, right? Or is there any special reason for it to be here?

PRs
stable-3_3_0

• pkp/pkp-lib#8511 Removed urldecode() from controlled vocabularies #8513
• [TESTS ONLY] pkp/pkp-lib#8511 Submodule update ##jonasraoni/bugfix/stable-3_3_0/8511-drop-urldecode-from-vocabs## ojs#3678

main

• Bugfix/main/8511 drop urldecode from vocabs #8515
• [TESTS ONLY] pkp/pkp-lib#8511 Submodule update ##jonasraoni/bugfix/main/8511-drop-… ojs#3681

[asmecher]

I believe it's due to the old UI tool we used to use for tags double-escaping things. I'm OK to remove it if it tests out to work well.

[jonasraoni]

It worked fine on my environment and the tests passed, so I've merged the PRs.