Convert session and cookie management to Laravel #9566

asmecher · 2023-12-08T19:36:32Z

Describe the bug
In preparation for work on OAuth/SSO, convert the underlying aspects of OJS/OMP/OPS from bespoke implementations to Laravel's toolset.

It is unclear how much of this can be done without needing to convert major aspects of the stack, e.g. authorization and request handling; this work should stop short of a major intervention for the moment.

Opportunities:

Replace SessionManager with SessionServiceProvider / session()
Replace Session/SessionDAO with Eloquent-based implementation (shipped with Laravel, I think)
Replace cookie implementation with CookieManager
Add a UserProvider implementation serving users to Laravel from current EntityDAO user implementation
Move CSRF token generation to Laravel (replacing homebrew implementation)

Pitfalls:

May need to tangle with lib/vendor/laravel/framework/src/Illuminate/Session/Middleware/* to get sessions to work properly. Not sure how deep that rabbit-hole goes yet.

PRs
pkp-lib --> #9596
ojs --> pkp/ojs#4132
ops --> pkp/ops#646
omp --> pkp/omp#1531
orcidProfile --> pkp/orcidProfile#313

The text was updated successfully, but these errors were encountered:

asmecher · 2023-12-08T19:38:13Z

I've experimented with this but think the next step is to work with the session middleware. Calling in @touhidurabir for a look!

Draft PRs (very much WIP):

To even start getting these working it's necessary to replace the sessions table with the new schema by dropping the current table and running the new migration (lib/pkp/classes/migration/install/SessionsMigration.php).

touhidurabir · 2024-01-04T06:52:30Z

@asmecher Draft PR
pkp-lib --> #9596
ojs --> pkp/ojs#4132

Login/Logout works fine and can access the app . Still need a lot of work on remember me, password update/reset, email/username update test, Login as other user etc . Also had to override few of laravel core classes .

touhidurabir · 2024-01-28T13:20:44Z

@asmecher please review the draft PR at

pkp-lib --> #9596
ojs --> pkp/ojs#4132

pretty much all done except few more clean up and Sign In As functionality .

jonasraoni · 2024-01-28T17:29:36Z

@touhidurabir you've mentioned there was something not working very well, but I guess it's solved by now, right? Or do you still need some ideas?

touhidurabir · 2024-01-29T04:22:26Z

@jonasraoni the part I was struggling with was the session auto regeneration part and it has been resolved . Thanks for taking time to look into it.

…ntation

…tion

touhidurabir · 2024-04-06T13:47:44Z

@asmecher all addressed . if all ok, should be good to merge .

* WIP replace sessions with Laravel * #9566 Laravel auth system integration * #9566 fixing session disable const checking and initialization * #9566 laravel session WIP * #9566 session regenration and old session manager clean up * #9566 added remember me functionality * #9566 fixed logout with auth key details persistence * #9566 fixed device force logout redirect issue * #9566 fixed login issue after migration from older session implementation * #9566 completed sign in/out as and updated session data update in PKPRequest::__destruct * #9566 updates based on PR review * #9566 added check to make sure seesion table exists before saving session * #9566 moved session storage update within register_shutdown_function * #9566 removed unused function param * #9566 added upgrade migration * #9566 fixed issue and doc blocks based on PR review * #9566 removed older implementation cookie issue override method as fixed by setting domain * #9566 removed previously added application upgrade settings from migration tool * #9566 trying to fix mysql build issue * #9566 added db service provider re-registration at install time * #9566 added cookie encryption ability * #9566 session disable check moved to PKPSessionGuard with session user_id key update * #9566 fixed typo * #9566 command line session issue * #9566 clean up of old session manager and dao related implementations * #9566 session default base path update * #9566 session default base path revert back * #9566 fixed cookie path issue * #9566 removed AUTH_KEY_* const usage and related code --------- Co-authored-by: Alec Smecher <alec@smecher.bc.ca>

pkp/pkp-lib#9566 replaced old session manager with new pkp session guard

asmecher · 2024-04-16T20:05:25Z

Congratulations, @touhidurabir, all merged!

asmecher mentioned this issue Dec 9, 2023

Add support for single sign on #9568

Open

touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Jan 4, 2024

pkp#9566 Laravel auth system integration

4aa75ff

touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Jan 4, 2024

pkp#9566 Laravel auth system integration

f37128a

touhidurabir added a commit to touhidurabir/ojs that referenced this issue Jan 4, 2024

pkp/pkp-lib#9566 Laravel auth system integration

39b5623

touhidurabir added a commit to touhidurabir/ojs that referenced this issue Jan 4, 2024

pkp/pkp-lib#9566 Submodule Update ##touhidurabir/i9566_main##

be10a86

This was referenced Jan 4, 2024

pkp/pkp-lib#9566 Laravel auth system integration #9596

Merged

pkp/pkp-lib#9566 Laravel auth system integration pkp/ojs#4132

Closed

touhidurabir added a commit to touhidurabir/ojs that referenced this issue Jan 4, 2024

pkp/pkp-lib#9566 Laravel auth system integration

60b2c0f

touhidurabir added a commit to touhidurabir/ojs that referenced this issue Jan 4, 2024

pkp/pkp-lib#9566 Submodule Update ##touhidurabir/i9566_main##

95e5794

touhidurabir self-assigned this Jan 8, 2024

touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Jan 15, 2024

pkp#9566 fixing session disable const checking and initialization

aac9b20

touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Jan 15, 2024

pkp#9566 Laravel auth system integration

000a1de

touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Jan 15, 2024

pkp#9566 fixing session disable const checking and initialization

65ce63d

touhidurabir added a commit to touhidurabir/ojs that referenced this issue Jan 15, 2024

pkp/pkp-lib#9566 Laravel auth system integration

f688c01

touhidurabir added a commit to touhidurabir/ojs that referenced this issue Jan 15, 2024

pkp/pkp-lib#9566 Submodule Update ##touhidurabir/i9566_main##

5ae29bd

touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Jan 22, 2024

pkp#9566 laravel session WIP

ea37bab

touhidurabir added a commit to touhidurabir/ojs that referenced this issue Jan 22, 2024

pkp/pkp-lib#9566 Submodule Update ##touhidurabir/i9566_main##

2dd27e0

touhidurabir added a commit to touhidurabir/ojs that referenced this issue Jan 22, 2024

pkp/pkp-lib#9566 laravel session WIP

bdab24d

touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Jan 28, 2024

pkp#9566 session regenration and old session manager clean up

d40caa4

touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Jan 28, 2024

pkp#9566 added remember me functionality

b30297f

touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Jan 28, 2024

pkp#9566 fixed logout with auth key details persistence

2a645b9

touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Jan 28, 2024

pkp#9566 fixed device force logout redirect issue

9aaa8d8

touhidurabir added a commit to touhidurabir/ojs that referenced this issue Jan 28, 2024

pkp/pkp-lib#9566 Submodule Update ##touhidurabir/i9566_main##

9332bed

jonasraoni added the Enhancement:2:Moderate A new feature or improvement that can be implemented in less than 4 weeks. label Jan 31, 2024

touhidurabir added a commit to touhidurabir/pkp-lib that referenced this issue Feb 7, 2024

pkp#9566 fixed login issue after migration from older session impleme…

eae810e

…ntation

touhidurabir added a commit to touhidurabir/ojs that referenced this issue Apr 2, 2024

pkp/pkp-lib#9566 laravel session WIP

cf266ac

touhidurabir added a commit to touhidurabir/ojs that referenced this issue Apr 2, 2024

pkp/pkp-lib#9566 added upgrade migration

c34e037

touhidurabir added a commit to touhidurabir/ojs that referenced this issue Apr 2, 2024

pkp/pkp-lib#9566 updated DB credentials to match export env variable

f6fc4cf

touhidurabir added a commit to touhidurabir/ojs that referenced this issue Apr 2, 2024

pkp/pkp-lib#9566 revert changes to default config file as it was

5d38cdc

touhidurabir added a commit to touhidurabir/ojs that referenced this issue Apr 2, 2024

pkp/pkp-lib#9566 added cookie encryption in config file

60b3b62

touhidurabir added a commit to touhidurabir/ojs that referenced this issue Apr 2, 2024

pkp/pkp-lib#9566 session disable check moved to PKPSessionGuard

3939dce

touhidurabir added a commit to touhidurabir/ojs that referenced this issue Apr 2, 2024

pkp/pkp-lib#9566 update cookie encryption key config typo and descrip…

4d54fc2

…tion

touhidurabir added a commit to touhidurabir/ojs that referenced this issue Apr 2, 2024

pkp/pkp-lib#9566 added 3.5.0 release doc

6e77d67

touhidurabir added a commit to touhidurabir/omp that referenced this issue Apr 2, 2024

pkp/pkp-lib#9566 Submodule Update ##touhidurabir/i9566_main##

55c7105

touhidurabir added a commit to touhidurabir/omp that referenced this issue Apr 2, 2024

pkp/pkp-lib#9566 Session and cookie management moved to Laravel toolset

7543a59

touhidurabir added a commit to touhidurabir/omp that referenced this issue Apr 2, 2024

pkp/pkp-lib#9566 Submodule Update ##touhidurabir/i9566_main##

83e4138

touhidurabir added a commit to touhidurabir/ops that referenced this issue Apr 2, 2024

pkp/pkp-lib#9566 Submodule Update ##touhidurabir/i9566_main##

af5b7ff

touhidurabir added a commit to touhidurabir/ops that referenced this issue Apr 2, 2024

pkp/pkp-lib#9566 Session and cookie management moved to Laravel toolset

43f24c6

touhidurabir added a commit to touhidurabir/ops that referenced this issue Apr 2, 2024

pkp/pkp-lib#9566 Submodule Update ##touhidurabir/i9566_main##

e3cc11b

touhidurabir added a commit to touhidurabir/ops that referenced this issue Apr 2, 2024

pkp/pkp-lib#9566 name fixed in release note

76d9e85

asmecher mentioned this issue Apr 2, 2024

Staled session IDs might lead to minor request failures #9859

Open

asmecher added a commit to pkp/ojs that referenced this issue Apr 16, 2024

pkp/pkp-lib#9566 Laravel auth system integration

3f69fa1

asmecher pushed a commit to pkp/ojs that referenced this issue Apr 16, 2024

pkp/pkp-lib#9566 Submodule Update ##touhidurabir/i9566_main##

a70d2d0

asmecher pushed a commit to pkp/ops that referenced this issue Apr 16, 2024

pkp/pkp-lib#9566 Session and cookie management moved to Laravel toolset

9128e44

asmecher pushed a commit to pkp/ops that referenced this issue Apr 16, 2024

pkp/pkp-lib#9566 name fixed in release note

6596918

asmecher pushed a commit to pkp/omp that referenced this issue Apr 16, 2024

pkp/pkp-lib#9566 Session and cookie management moved to Laravel toolset

40db7a7

asmecher added a commit to pkp/orcidProfile that referenced this issue Apr 16, 2024

Merge pull request #313 from touhidurabir/i9566_main

61066d8

pkp/pkp-lib#9566 replaced old session manager with new pkp session guard

asmecher closed this as completed Apr 16, 2024

asmecher added this to the 3.5.0 LTS milestone Apr 16, 2024

This was referenced Apr 17, 2024

3.5 LTS Dependency maintenance and updates #9239

Open

Introduce APP KEY feature #9895

Open

pkp/pkp-lib#5885 Review remainder update #9612

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Convert session and cookie management to Laravel #9566

Convert session and cookie management to Laravel #9566

asmecher commented Dec 8, 2023 •

edited by touhidurabir

asmecher commented Dec 8, 2023

touhidurabir commented Jan 4, 2024

touhidurabir commented Jan 28, 2024

jonasraoni commented Jan 28, 2024 •

edited

touhidurabir commented Jan 29, 2024

touhidurabir commented Apr 6, 2024

asmecher commented Apr 16, 2024

Convert session and cookie management to Laravel #9566

Convert session and cookie management to Laravel #9566

Comments

asmecher commented Dec 8, 2023 • edited by touhidurabir

asmecher commented Dec 8, 2023

touhidurabir commented Jan 4, 2024

touhidurabir commented Jan 28, 2024

jonasraoni commented Jan 28, 2024 • edited

touhidurabir commented Jan 29, 2024

touhidurabir commented Apr 6, 2024

asmecher commented Apr 16, 2024

asmecher commented Dec 8, 2023 •

edited by touhidurabir

jonasraoni commented Jan 28, 2024 •

edited