pkp/pkp-lib#9453 Let reviewers view their recommendations for previous rounds #9526
Conversation
|
|
||
| $this->insertNewStageAssignmentIfEmpty($request, $reviewSubmissionId); |
There was a problem hiding this comment.
Why do we need inserting a new stage assignment here and in the step() method?
| */ | ||
| function authorize($request, &$args, $roleAssignments): bool | ||
| { | ||
| $this->addPolicy(new RoleBasedHandlerOperationPolicy( |
There was a problem hiding this comment.
Is checking the role enough here? Shouldn't we also check if a reviewer has was assigned to the assignment? I see that the current ReviewAssignmentAccessPolicy doesn't allow that. Maybe create a new policy, something like ReviewPreviousRoundsAccessPolicy?
There was a problem hiding this comment.
@asmecher, what do you think about this?
| $('#okButtonForm').pkpHandler('$.pkp.controllers.form.AjaxFormHandler'); | ||
| {rdelim}); | ||
| </script> | ||
| <div id="historyTab"> |
There was a problem hiding this comment.
Some styling isn't aligned, like font size, padding/margin... Maybe using FormBuilderVocabulary can help? @jardakotesovec, what do you think?
| <h4>{translate key="reviewer.submission.emailLog"}:</h4> | ||
| {if isset($declineEmail)} | ||
| <div> | ||
| <p>{$declineEmail->getSubject()}<br /> |
There was a problem hiding this comment.
Please review the Smarty template to make sure that content is escaped appropriately. Plaintext content should go through |escape, and limited HTML content (e.g. email bodies) should go through |strip_unsafe_html.
nibou230
force-pushed
the
9453
branch
2 times, most recently
from
a76c935
to
8398f00
Compare
|
Hi @jardakotesovec, hi @asmecher, it seems that we are nearly there for this feature. Can you confirm if everything is OK? |
|
Closed in favor of #9920 |
How to test?