Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pkp-lib][main] #9674 Port StageAssignmentDAO and StageAssignment to Eloquent Model #9675

Merged
merged 7 commits into from
Apr 25, 2024

Conversation

defstat
Copy link
Collaborator

@defstat defstat commented Jan 31, 2024

No description provided.

Copy link
Collaborator

@Vitaliy-1 Vitaliy-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks great! Just few minor comments, otherwise is ready to merge.

classes/decision/Repository.php Outdated Show resolved Hide resolved
@@ -21,7 +21,7 @@
use APP\facades\Repo;
use PKP\db\DAORegistry;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This import statement could be dropped

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

classes/submission/maps/Schema.php Outdated Show resolved Hide resolved
classes/submission/reviewRound/ReviewRound.php Outdated Show resolved Hide resolved
classes/stageAssignment/StageAssignment.php Outdated Show resolved Hide resolved
classes/stageAssignment/StageAssignment.php Outdated Show resolved Hide resolved
classes/stageAssignment/StageAssignment.php Show resolved Hide resolved
@defstat defstat merged commit 3cb57cd into pkp:main Apr 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants