Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Execute command where all params are optional #4

Closed
stakach opened this issue Mar 19, 2020 · 5 comments
Closed

Execute command where all params are optional #4

stakach opened this issue Mar 19, 2020 · 5 comments
Assignees
@MrYuion

Comments

@stakach
Copy link
Member

stakach commented Mar 19, 2020

Clicking send on a function where all parameters are optional stops the component from updating (can't select a different function) and does not execute the command.

image
@stakach stakach added this to the Backoffice Release milestone Mar 19, 2020
MrYuion added a commit that referenced this issue Mar 20, 2020
@MrYuion
fix(system-exec): fix executing items with all optional params
f7eb77d 
Fixes #4
@stakach
Copy link
Member Author

stakach commented Mar 20, 2020

Seems the latest build has introduced a new issue in this regard
image

Also listing modules on the system page
image

@MrYuion
Copy link
Collaborator

MrYuion commented Mar 21, 2020

@stakach, I've been a bit confused as to how the module name should be determine.
Can you please clarify that?

@stakach
Copy link
Member Author

stakach commented Mar 21, 2020

Module Name should be: module.driver.name
Class should be: module.custom_name || module.name however custom_name should be ignored if null or "" blank.

Then the index on the class column there is just Class_count_of_class_type

so Classes above should be

  • PrivateHelper_1
  • Lighting_1
  • PrivateHelper_2

@MrYuion
Copy link
Collaborator

MrYuion commented Mar 22, 2020

module.driver isn't returned on the index requests.

MrYuion added a commit that referenced this issue Mar 22, 2020
@MrYuion
chore(modules): tweak display of module names
d820dd1 
Fixes #4
@stakach
Copy link
Member Author

stakach commented Mar 26, 2020

looking good!

@stakach stakach closed this as completed Mar 26, 2020
github-actions bot pushed a commit that referenced this issue Apr 20, 2020
@semantic-release-bot
chore(release): 1.0.0 [skip ci]
024915d 
# 1.0.0 (2020-04-20)

### Bug Fixes

* **modules:** fix validation of ip addresses ([5976bb4](5976bb4)), closes [#26](#26)
* fix minor routing issues ([5850ff5](5850ff5))
* **build:** fix compilation issues ([2ed2227](2ed2227))
* **debug-output:** scroll view to bottom when content updates ([c89d520](c89d520)), closes [#13](#13)
* **drivers:** fix listing commits for edits ([3e85eac](3e85eac)), closes [#27](#27)
* **drivers:** fix logic of driver execs ([4120f09](4120f09))
* **drivers:** fix saving settings when creating drivers ([dcf8ccf](dcf8ccf)), closes [#23](#23)
* **drivers:** fix updating driver and commit listing on changes ([426fa30](426fa30)), closes [#20](#20)
* **drivers:** update about display values ([a4b35c5](a4b35c5))
* **drivers:** update drivers to post repository details ([9a98f2f](9a98f2f))
* **engine-admin:** fix spinners on database actions ([7c1275e](7c1275e))
* **modules:** fix propagating local changes when adding modules to sys ([22fe99f](22fe99f)), closes [#24](#24)
* **settings:** fix making mocked builds ([d0305f5](d0305f5))
* **system-exec:** fix executing items with all optional params ([f7eb77d](f7eb77d)), closes [#4](#4)
* **system-exec:** fix parsing parameters ([e125136](e125136))
* **system-modules:** toggle running state with power actions ([3b25d63](3b25d63)), closes [#21](#21)
* **system-modules:** update local copy of system after adding a module ([9424637](9424637)), closes [#24](#24)
* **systems:** fix adding and removing zones ([7ccfbb7](7ccfbb7))
* **systems:** fix listing of system zones ([ad6d7a2](ad6d7a2))
* **users:** fix password logic for form ([3fea867](3fea867)), closes [#35](#35)
* **view-state:** fix determining mod name ([6460a37](6460a37))
* **zones:** fix listening to modal events ([8ed7bf0](8ed7bf0))
* **zones:** fix spliting tags when editing ([2405cac](2405cac)), closes [#36](#36)
* **zones:** fix tab counts ([6ff7da9](6ff7da9)), closes [#34](#34)

### Features

* **build:** cleanup build process ([11bc5ef](11bc5ef))
* **engine-admin:** add admin section to engine ([21adbb3](21adbb3))
* **metadata:** add logic for zone metadata ([0ee1c6c](0ee1c6c)), closes [#19](#19)
* **settings:** allow viewing and editing settings from about pages ([f54ec76](f54ec76))
* **sys-exec:** add modal for viewing exec responses ([920251d](920251d))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MrYuion MrYuion

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stakach @MrYuion