Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use of uninitialized value in concatenation (.) or string at .../Plack/Handler/Apache1.pm line 57. #204

Closed
davehamptonusa opened this issue May 9, 2011 · 1 comment
Closed

Use of uninitialized value in concatenation (.) or string at .../Plack/Handler/Apache1.pm line 57. #204

davehamptonusa opened this issue May 9, 2011 · 1 comment

Comments

@davehamptonusa
Copy link

The error is caused here:

my $vpath    = $env->{SCRIPT_NAME} . $env->{PATH_INFO};

When there is no PATH_INFO.

For Example, http://www.example.com/account?acctnum=73836 has no PATH_INFO and throws a warning.

Simple fix:

my $vpath = $env->{PATH_INFO} ? $env->{SCRIPT_NAME} . $env->{PATH_INFO} :  $env->{SCRIPT_NAME} ;

Thanks
miyagawa added a commit that referenced this issue May 17, 2011
@miyagawa
Checking in changes prior to tagging of version 0.9979.
60fb5c4 
Changelog diff is:

diff --git a/Changes b/Changes
index 97a9d3b..ce2ef5d 100644
--- a/Changes
+++ b/Changes
@@ -2,6 +2,18 @@ Revision history for Perl extension Plack

 Take a look at http://github.com/miyagawa/Plack/issues for the planned changes before 1.0 release.

+0.9979  Tue May 17 09:54:03 PDT 2011
+    [BUG FIXES]
+        - Fixed Middleware::AccessLog's default %t format to match Apache's format
+        - Fixed a warning in Apache1 handler where PATH_INFO doesn't exist #204
+        - Fixed a bad test relying on new Test::More versions
+
+    [IMPROVEMENTS]
+        - Fixed Lint to accept bare in-memory filehandle per http://stackoverflow.com/questions/6011793/
+        - Added setup_env() to Plack::Handler::CGI (markstos)
+        - Added a non-blocking Hello World example in eg/dot-psgi
+        - Doc cleanup
+
 0.9978  Wed May  4 11:29:12 PDT 2011
     [TEST FIXES]
         - Fixed a failing output_encoding.t because of FCGI dependencies
@davehamptonusa
Copy link
Author

much cleaner fix, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@miyagawa @davehamptonusa