Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add EmbeddingSegmentsSum op #1639

Merged
merged 3 commits into from
Dec 21, 2020
Merged

add EmbeddingSegmentsSum op #1639

merged 3 commits into from
Dec 21, 2020

Conversation

haoyouab
Copy link
Contributor

This is based on PR #1636.

Note: as discussed before, there's no 'zero-like' operation currently so broadcast op with compute_shape to get the shape of tensors is used.

tzerrell
tzerrell approved these changes Dec 21, 2020
View reviewed changes
Copy link
Contributor

@tzerrell tzerrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 372b8ff into plaidml-v1 Dec 21, 2020
@mergify mergify bot deleted the zhibinli-embeddingsegmentssum branch December 21, 2020 20:13
@haoyouab haoyouab mentioned this pull request Dec 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzerrell tzerrell tzerrell approved these changes

@flaub flaub Awaiting requested review from flaub

@jbruestle jbruestle Awaiting requested review from jbruestle

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@haoyouab @tzerrell