Burndown isParentOf function throws error on tasks without body

[bavicj]

TypeError: Cannot read properties of null (reading 'indexOf')

[jens-markussen]

Hi @bavicj. Can you be a bit more specific here. Are you trying to deploy yoda-webhook function? What are the hard-coded parts (e.g. owner1 = rentalport). issue1 and issue2 in the code is assume to be full GitHub issues. It somehow seems like you are trying to unit-test yoda-webhook?

[bavicj]

Hi @jens-markussen
Thank for quick reply. We are using https://hewlettpackard.github.io/yoda/yoda-burndown.html -> Show Table functionality.
There are no hardcoded parts (its just google dev tools debugger, showing current values).

When I clicked on button "Show table" , no table was rendered for some milestones, and error was thrown in javascript console. So I only debugged it and found out that you are not checking whether issue2.body is null before accessing its indexOf method. I understand you are checking issue body to find specific texts, but can be that some tasks have only title (were created directly from github project view), without need to have actual body/comment.

[jens-markussen]

Ok, got it. Will fix !

[jens-markussen]

Issue reproduced. Interestingly it does not occur in GitHub Enterprise (GHE) version which is in use at my company (HPE).

[jens-markussen]

Fixed. A few more protections had to be added for issues without body. I cannot be 100% sure that these work perfectly across all tools. If any problems detected, do let us know.