Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul GitHub workflow to be reused across repos #26

Merged
merged 5 commits into from
Oct 26, 2023

Conversation

nsoranzo
Copy link
Collaborator

@nsoranzo nsoranzo commented Oct 25, 2023

Merge the 4 very similar workflows into a reusable one.

Also:

  • Actually define python-version (3.11, as env) and install it
  • Split out some steps from the "Run multi-line script"
  • Install stable Planemo from PyPI instead of GitHub master branch
  • Use GITHUB_TOKEN environment variable instead of gh auth login
  • Reduce number of the slow gh pr list calls from 4 to 2 per repo
  • Quote environment variables
  • Update action versions
  • Remove use of the ssh-agent action
  • Allow to run the workflow manually
  • Remove unused file

Also:
- Actually define `python-version` (3.11, as env) and install it
- Split out some steps from the "Run multi-line script"
- Install stable Planemo from PyPI instead of GitHub master branch
- Use `GITHUB_TOKEN` environment variable instead of `gh auth login`
- Reduce number of `gh pr list` calls from 4 to 2 per repo
- Quote environment variables
Copy link
Collaborator

@bernt-matthias bernt-matthias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Will this also restore planemo-autoupdate as PR author (at the moment its lldelisle)?

.github/workflows/autoupdate.yml Outdated Show resolved Hide resolved
Co-authored-by: M Bernt <m.bernt@ufz.de>
@nsoranzo
Copy link
Collaborator Author

Looks good to me. Will this also restore planemo-autoupdate as PR author (at the moment its lldelisle)?

I believe this is due to the PAT secret being used, which comes from Lucille.
Who has login access to the planemo-autoupdate GitHub account? @simonbray ?

@bgruening
Copy link
Collaborator

I converted it into an organization... you should have access.

grafik

@nsoranzo nsoranzo merged commit 7b1f126 into planemo-autoupdate:main Oct 26, 2023
@nsoranzo nsoranzo deleted the PAT_update branch October 26, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants