-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AssemblyName to Executable to make shortcut naming #2173
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we changed its assembly name, they will not be any NineChronicles.Headless.Executable.dll
file 🤔
ENTRYPOINT ["dotnet", "NineChronicles.Headless.Executable.dll"] |
So Dockerfiles will not work and it should be updated too.
And maybe it should affect planetarium/9c-infra
repository 🤔 cc @area363
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
I shared this change in the community. Discord link: https://discord.com/channels/928926944937013338/1032212649175416862/1136442028411080775 |
…tarium#2173)" This reverts commit a2f3871.
…tarium#2173)" This reverts commit a2f3871.
Revert "Add AssemblyName to Executable to make shortcut naming (#2173)"
Revert "Add AssemblyName to Executable to make shortcut naming (#2173)"
…tarium#2173)" This reverts commit a2f3871.
Resolves #1687