Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AssemblyName to Executable to make shortcut naming #2173

Merged
merged 4 commits into from
Aug 2, 2023

Conversation

XxshiftxX
Copy link
Contributor

Resolves #1687

@moreal moreal requested a review from boscohyun August 1, 2023 10:17
Copy link
Contributor

@moreal moreal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we changed its assembly name, they will not be any NineChronicles.Headless.Executable.dll file 🤔

ENTRYPOINT ["dotnet", "NineChronicles.Headless.Executable.dll"]

So Dockerfiles will not work and it should be updated too.
And maybe it should affect planetarium/9c-infra repository 🤔 cc @area363

https://github.com/planetarium/9c-infra/blob/e0cd36422dc2acb93371f7c3ae67603ab7680a90/9c-main/chart/templates/remote-headless.yaml#L27

@pull-request-quantifier-deprecated

This PR has 8 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Small
Size       : +5 -3
Percentile : 3.2%

Total files changed: 4

Change summary by file extension:
.amd64 : +1 -1
.arm64v8 : +1 -1
.csproj : +2 -0
Dockerfile : +1 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@moreal
Copy link
Contributor

moreal commented Aug 2, 2023

I shared this change in the community. Discord link: https://discord.com/channels/928926944937013338/1032212649175416862/1136442028411080775

@moreal moreal enabled auto-merge (squash) August 2, 2023 23:41
@moreal moreal merged commit a2f3871 into development Aug 2, 2023
15 checks passed
moreal added a commit to moreal/NineChronicles.Headless that referenced this pull request Aug 8, 2023
moreal added a commit to moreal/NineChronicles.Headless that referenced this pull request Aug 11, 2023
area363 added a commit that referenced this pull request Aug 11, 2023
Revert "Add AssemblyName to Executable to make shortcut naming (#2173)"
ipdae pushed a commit that referenced this pull request Aug 17, 2023
Revert "Add AssemblyName to Executable to make shortcut naming (#2173)"
U-lis pushed a commit that referenced this pull request Aug 22, 2023
riemannulus pushed a commit to riemannulus/NineChronicles.Headless that referenced this pull request Sep 5, 2023
)

Co-authored-by: Lee Dogeon <dev.moreal@gmail.com>
riemannulus pushed a commit to riemannulus/NineChronicles.Headless that referenced this pull request Sep 5, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Publish NineChornicles.Headless with shortcut naming, ncd
2 participants