Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit size of block (byte-wise) #201

Closed
longfin opened this issue Apr 15, 2019 · 5 comments · Fixed by #1050
Closed

Limit size of block (byte-wise) #201

longfin opened this issue Apr 15, 2019 · 5 comments · Fixed by #1050
Assignees
Labels
discussion needed We need to dicuss about this suggestion Suggestion or feature request

Comments

@longfin
Copy link
Member

longfin commented Apr 15, 2019

Currently, Libplanet doesn't define how many transactions will be stored in a block, and the size of a transaction is also not explicitly defined. however, in order to predict figures such as storage space and network traffic, it is necessary to be able to determine how much physical space a block occupies.

The block size is not a protocol-level constraint, and game developers need to adjust the unit to synchronize the status of each game, so I suggest offering it as an configurable parameter.

@longfin longfin added suggestion Suggestion or feature request discussion needed We need to dicuss about this labels Apr 15, 2019
@stale
Copy link

stale bot commented Oct 30, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale The issue is stale label Oct 30, 2019
@stale stale bot closed this as completed Nov 6, 2019
@limebell limebell reopened this Nov 7, 2019
@stale stale bot removed the stale The issue is stale label Nov 7, 2019
@stale
Copy link

stale bot commented Jan 6, 2020

This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions.

@stale stale bot added the stale The issue is stale label Jan 6, 2020
@longfin longfin removed the stale The issue is stale label Jul 13, 2020
@longfin
Copy link
Member Author

longfin commented Jul 13, 2020

Block size can be defined in two ways.

  1. total bytes
  2. a count of transactions.

In many other blockchain projects, they prefer to limit by byte size. it's useful to predict disk space, network traffic, and discovering attack scenarios.
but limiting by a count of transactions can be also useful because it can affect the performance of executing blocks directly. (and it can be more straightforward for game devs)

So, it would be useful if we add parameters like as TotalBlockSize and TotalTxCount to BlockPolicy and restrict block using them.

@longfin longfin self-assigned this Jul 14, 2020
@stale
Copy link

stale bot commented Sep 12, 2020

This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions.

@stale stale bot added the stale The issue is stale label Sep 12, 2020
@dahlia dahlia changed the title Limit the size of the block. Limit size of block Oct 20, 2020
@stale stale bot removed the stale The issue is stale label Oct 20, 2020
@dahlia dahlia assigned dahlia and unassigned longfin Oct 20, 2020
@dahlia
Copy link
Contributor

dahlia commented Oct 20, 2020

I'm going to work on this.

@dahlia dahlia changed the title Limit size of block Limit size of block (byte-wise) Oct 20, 2020
dahlia added a commit to dahlia/libplanet that referenced this issue Oct 22, 2020
dahlia added a commit to dahlia/libplanet that referenced this issue Oct 22, 2020
dahlia added a commit to dahlia/libplanet that referenced this issue Oct 26, 2020
dahlia added a commit to dahlia/libplanet that referenced this issue Oct 26, 2020
dahlia added a commit to dahlia/libplanet that referenced this issue Oct 26, 2020
dahlia added a commit to dahlia/libplanet that referenced this issue Oct 26, 2020
OnedgeLee pushed a commit to OnedgeLee/libplanet that referenced this issue Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion needed We need to dicuss about this suggestion Suggestion or feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants