Limit the maximum bytes length of blocks #1050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dahlia
requested review from
longfin,
limebell,
earlbread,
riemannulus and
moreal
Codecov Report
@@ Coverage Diff @@
## main #1050 +/- ##
==========================================
- Coverage 88.39% 88.34% -0.05%
==========================================
Files 342 344 +2
Lines 31382 31616 +234
==========================================
+ Hits 27739 27931 +192
- Misses 1976 2007 +31
- Partials 1667 1678 +11
|
earlbread
previously approved these changes
Oct 26, 2020
|
@planetarium/libplanet Please review this. |
limebell
reviewed
Oct 26, 2020
riemannulus
previously approved these changes
Oct 26, 2020
longfin
reviewed
Oct 26, 2020
Merged
limebell
previously approved these changes
Oct 26, 2020
dahlia
dismissed stale reviews from limebell, riemannulus, and earlbread
via
d05c3f8
dahlia
force-pushed
the
block-size-limit
branch
from
e7d963b
to
d05c3f8
Compare
|
@planetarium/libplanet Addressed reviews and rebased. Please review this again! |
longfin
previously approved these changes
Oct 26, 2020
earlbread
previously approved these changes
Oct 26, 2020
limebell
previously approved these changes
Oct 26, 2020
riemannulus
previously approved these changes
Oct 26, 2020
moreal
previously approved these changes
Oct 26, 2020
dahlia
dismissed stale reviews from moreal, riemannulus, limebell, earlbread, and longfin
via
76a966a
dahlia
force-pushed
the
block-size-limit
branch
from
d05c3f8
to
76a966a
Compare
|
@planetarium/libplanet I rebased. Please review this again. |
dahlia
requested review from
longfin,
limebell,
earlbread,
moreal and
riemannulus
earlbread
approved these changes
Oct 26, 2020
longfin
approved these changes
Oct 26, 2020
riemannulus
approved these changes
Oct 26, 2020
moreal
approved these changes
Oct 26, 2020
|
@planetarium/libplanet As it seems to reach Azure Pipelines' rate limit, the build is being timed out again and again. Instead retring the build again, I am going to merge this anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #201. Please read added changelogs for details.