Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mixed-case checksum address encoding #33

Closed
2 tasks done
dahlia opened this issue Jan 14, 2019 · 1 comment
Closed
2 tasks done

Mixed-case checksum address encoding #33

dahlia opened this issue Jan 14, 2019 · 1 comment

Comments

@dahlia
Copy link
Member

@dahlia dahlia commented Jan 14, 2019

The current Address object provides hexadecimal formatting, but it always returns only lowercase letters. Since we are following the same address scheme to Ethereum by design, we should follow EIP 55 as well.

This task consists of two subtasks:

  • Making the formatting method to return a mixed-case EIP 55 string. → #43
  • Adding a new constructor to take a hexadecimal address string. If a string is mixed-case and the checksum is invalid it should throw an exception. → #53
@dahlia
Copy link
Member Author

@dahlia dahlia commented Feb 6, 2019

Closed by #43 and #53.

@dahlia dahlia closed this Feb 6, 2019
limebell pushed a commit to limebell/libplanet that referenced this issue Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant